Skip to content

Commit 6664123

Browse files
authored
Merge pull request #2 from oslabs-beta/ax_tree
resolved promise bug due to not detaching chrome.debugger
2 parents e9cc9a2 + 7bee9cd commit 6664123

File tree

1 file changed

+2
-17
lines changed

1 file changed

+2
-17
lines changed

src/extension/background.js

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -133,23 +133,6 @@ function changeCurrLocation(tabObj, rootNode, index, name) {
133133
}
134134
}
135135

136-
// get ax tree
137-
// function getAccessibilityTree(tabId) {
138-
// chrome.debugger.attach({ tabId: tabId }, '1.3', function () {
139-
// chrome.debugger.sendCommand({ tabId: tabId }, '1.3', 'Accessibility.enable', {}, function () {
140-
// chrome.debugger.sendCommand(
141-
// { tabId: tabId },
142-
// '1.3',
143-
// 'Accessibility.getFullAxTree',
144-
// {},
145-
// function (response) {
146-
// console.log(response);
147-
// },
148-
// );
149-
// });
150-
// });
151-
// }
152-
153136
/*
154137
The 'chrome.runtime' API allows a connection to the background service worker (background.js).
155138
This allows us to set up listener's for when we connect, message, and disconnect the script.
@@ -265,6 +248,7 @@ chrome.runtime.onConnect.addListener((port) => {
265248
return true;
266249

267250
case 'jumpToSnap':
251+
// chrome.debugger.detach({ tabId: tabId });
268252
// console.log('background.js: jumpToSnap:', getAccessibilityTree(tabId));
269253
chrome.debugger.attach({ tabId: tabId }, '1.3', () => {
270254
chrome.debugger.sendCommand({ tabId: tabId }, 'Accessibility.enable', () => {
@@ -274,6 +258,7 @@ chrome.runtime.onConnect.addListener((port) => {
274258
{},
275259
(response) => {
276260
console.log(response);
261+
chrome.debugger.detach({ tabId: tabId });
277262
},
278263
);
279264
});

0 commit comments

Comments
 (0)