You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
// As of V22, if multiple monitors are used, it would open the reactime panel on the other screen, which was inconvenient when opening repeatedly for debugging.
502
501
// V23 fixes this by making use of chrome.windows.getCurrent to get the top and left of the screen which invoked the extension.
503
-
// The reason you must use chrome.windows.getCurrent is that as of chrome manifest V3, background.js is a 'service worker', which does not have access to the DOM or to the native 'window' method.
504
-
// chrome.windows.getCurrent allows us to still get the window from within a service worker. It returns a promise (asynchronous), so all resulting functionality must happen in the callback function,
505
-
// or it will run before 'invokedScreen' variables have been captured.
502
+
// As of chrome manifest V3, background.js is a 'service worker', which does not have access to the DOM or to the native 'window' method, so we use chrome.windows.getCurrent(callback)
503
+
// chrome.windows.getCurrent returns a promise (asynchronous), so all resulting functionality must happen in the callback function, or it will run before 'invokedScreen' variables have been captured.
// // this was a test to see if I could dynamically set the left property to be the 0 origin of the invoked DISPLAY (as opposed to invoked window).
508
507
// // this would allow you to split your screen, keep the browser open on the right side, and reactime always opens at the top left corner.
509
-
// // unfortunately it does not tell you which display is the one that invoked it, just the array of all available displays. Leaving for future iterators
508
+
// // however it does not tell you which display is the one that invoked it, just gives the array of all available displays. Depending on your monitor setup, it may differ. Leaving for future iterators
//JR 1.8.23: this code fixes the no target error (still gets stuck on reactdevtools installed check), but creates an error where the addNewSnapshots reducer has an error.
528
+
//JR 1.9.23: this code fixes the no target error on load by triggering chrome tab reload before the panel spins up.
529
+
// It does not solve the root issue, which was deeply researched during v23 but we ran out of time to solve. Please see the readme for more information.
0 commit comments