added comments about a potential bugfix in background.js (should also be implemented in mainslice

Author: Oliver-Cho

src/app/slices/mainSlice.ts

@@ -47,10 +47,13 @@ export const mainSlice = createSlice({
       tabs[currentTab].playing = false;
 
       const lastSnapshot = tabs[currentTab].snapshots[tabs[currentTab].snapshots.length - 1]; // the most recent snapshot
+      const lastAxSnapshot = tabs[currentTab].axSnapshots[tabs[currentTab].axSnapshots.length - 1]; // the most recent snapshot
 
       tabs[currentTab].hierarchy.stateSnapshot = { ...lastSnapshot }; // resets hierarchy to page last state recorded
+      tabs[currentTab].hierarchy.axSnapshot = lastAxSnapshot; // resets hierarchy to page last state recorded
       tabs[currentTab].hierarchy.children = []; // resets hierarchy
       tabs[currentTab].snapshots = [lastSnapshot]; // resets snapshots to page last state recorded
+      tabs[currentTab].axSnapshots = [lastAxSnapshot]; // resets snapshots to page last state recorded
 
       // resets currLocation to page last state recorded
       tabs[currentTab].currLocation = tabs[currentTab].hierarchy;

src/extension/background.js

@@ -270,9 +270,11 @@ chrome.runtime.onConnect.addListener((port) => {
           // resets hierarchy to page last state recorded
           ...tabsObj[tabId].snapshots[0],
         };
-        tabsObj[tabId].axSnapshots = tabsObj[tabId].axSnapshots[0];
-        tabsObj[tabId].hierarchy.axSnapshot = tabsObj[tabId].axSnapshots[0]; //what about other hierarchy properties? Shouldn't those be reset as well?
-        // other hierarchy properties do not have to be set because you maintain the root history node
+        tabsObj[tabId].axSnapshots = [
+          tabsObj[tabId].axSnapshots[tabsObj[tabId].axSnapshots.length - 1],
+        ]; // resets axSnapshots to page last recorded
+        tabsObj[tabId].hierarchy.axSnapshot = tabsObj[tabId].axSnapshots[0]; // resets hierarchy to page of last ax tree recorded
+        // SHOULDN'T HIERARCHY.AXSNAPSHOT AND HIERARCHY.SNAPSHOT BE RESET BASED ON CURRLOCATION, NOT LAST SNAP RECORDED BECAUSE WHAT IF JUMPING TO PREVIOUS SNAPSHOT AND THEN CLEAR. WOULDN'T THAT REQUIRE UPDATING THE DEMO APP TO THE LAST STATE RECORDED AS WELL?
         tabsObj[tabId].currLocation = tabsObj[tabId].hierarchy; // resets currLocation to page last state recorded
         tabsObj[tabId].index = 1; //reset index
         tabsObj[tabId].currParent = 0; // reset currParent
@@ -500,10 +502,14 @@ chrome.runtime.onMessage.addListener(async (request, sender, sendResponse) => {
       const previousSnap =
         tabsObj[tabId]?.currLocation?.stateSnapshot?.children[0]?.componentData?.actualDuration;
       const incomingSnap = request.payload.children[0].componentData.actualDuration;
-      if (previousSnap === incomingSnap) break;
+      if (previousSnap === incomingSnap) {
+        console.log('background.js: previousSnap===incomingSnap');
+        break;
+      }
 
       // Or if it is a snapShot after a jump, we don't record it.
       if (reloaded[tabId]) {
+        console.log('background.js: reloaded[tabId]');
         // don't add anything to snapshot storage if tab is reloaded for the initial snapshot
         reloaded[tabId] = false;
       } else {
@@ -519,6 +525,8 @@ chrome.runtime.onMessage.addListener(async (request, sender, sendResponse) => {
             'background.js: bottom of recordSnap: tabsObj[tabId]:',
             JSON.parse(JSON.stringify(tabsObj[tabId])),
           );
+        } else {
+          console.log('background.js: tabsObj[tabId][index]');
         }
       }
 
@@ -531,6 +539,8 @@ chrome.runtime.onMessage.addListener(async (request, sender, sendResponse) => {
             sourceTab,
           }),
         );
+      } else {
+        console.log('background.js: portsArr.length < 0');
       }
       break;
     }