Skip to content

Commit 81cb4e5

Browse files
committed
Cleaning up create tree, createComponent & tree files to reduce complexity
1 parent 06b52a2 commit 81cb4e5

File tree

5 files changed

+309
-334
lines changed

5 files changed

+309
-334
lines changed

src/backend/controllers/createTree/createComponentActionsRecord.ts

Lines changed: 2 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -38,24 +38,8 @@ import Tree from '../../models/tree';
3838
// passes the data down to its components
3939
import componentActionsRecord from '../../models/masterState';
4040
import { getHooksStateAndUpdateMethod } from './statePropExtractors';
41+
import { nextJSDefaultComponent } from '../../models/filterConditions';
4142

42-
const nextJSDefaultComponent = new Set([
43-
'Root',
44-
'Head',
45-
'AppContainer',
46-
'Container',
47-
'ReactDevOverlay',
48-
'ErrorBoundary',
49-
'AppRouterContext',
50-
'SearchParamsContext',
51-
'PathnameContextProviderAdapter',
52-
'PathnameContext',
53-
'RouterContext',
54-
'HeadManagerContext',
55-
'ImageConfigContext',
56-
'RouteAnnouncer',
57-
'Portal',
58-
]);
5943
// ------------------------CREATE COMPONENT ACTIONS RECORD----------------------
6044
/**
6145
* This is a recursive function that runs after Fiber commit, if user navigating to a new route during jumping. This function performs the following logic:
@@ -64,7 +48,6 @@ const nextJSDefaultComponent = new Set([
6448
* @param currentFiberNode A Fiber object
6549
* @param circularComponentTable A table content visited Fiber nodes
6650
*/
67-
// TODO: Not sure why the ritd need to be outside of the createTree function. Want to put inside, but in case this need to be keep track for front end.
6851
export default function createComponentActionsRecord(
6952
currentFiberNode: Fiber,
7053
circularComponentTable: Set<Fiber> = new Set(),
@@ -91,7 +74,7 @@ export default function createComponentActionsRecord(
9174
elementType?.render?.name ||
9275
elementType?.name ||
9376
'nameless';
94-
// console.log('LinkFiber', {
77+
// console.log('createComponentActionsRecord', {
9578
// currentFiberNode,
9679
// // tag,
9780
// // elementType,

0 commit comments

Comments
 (0)