Skip to content

Commit 963e823

Browse files
authored
Merge pull request #296 from llam722/louis-patch-1
Add compatibility for Nodev18.12.1
2 parents 92ce211 + 01bd30e commit 963e823

File tree

5 files changed

+19
-4
lines changed

5 files changed

+19
-4
lines changed

DeveloperREADME.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ cd reactime
1818
npm install --force
1919
npm run build
2020
```
21+
<b>With release of Node v18.12.1 (LTS) on 11/4/22, the script has been updated to 'npm run dev' || 'npm run build' for backwards compatibility.<br/>
22+
For version Node v16.16.0, please use script 'npm run devlegacy' || 'npm run buildlegacy'</b>
2123

2224
4. Spin up the demo application.
2325

README.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030

3131
<h5 align="center">
3232
<br>
33-
<a href="./README.rus.md">🇷🇺 &nbsp; РУССКАЯ ВЕРСИЯ</a> &nbsp;&nbsp; <a href="./README.fr.md">🇫🇷 &nbsp; VERSION FRANÇAISE</a>
33+
<a href="./README.rus.md">🇷🇺 &nbsp; РУССКАЯ ВЕРСИЯ</a> &nbsp;&nbsp; <a href="./README.fr.md">🇫🇷 &nbsp; VERSION FRANÇAISE</a> &nbsp;&nbsp; <a href='/DeveloperREADME.md'>DEVELOPER INSTALL</a> &nbsp;&nbsp; <a href='./src/README.md'>DEVELOPER README</a>
3434
<br>
3535
</h5>
3636
<br>
@@ -47,6 +47,9 @@
4747

4848
The primary purpose of this update is to allow easier understanding of Reactime's codebase by individuals or groups wishing to further update Reactime, keeping this great developer tool alive.
4949

50+
With release of Node v18.12.1(LTS) on 11/4/22, the script has been updated to 'npm run dev' || 'npm run build' for backwards compatibility.<br/>
51+
For version Node v16.16.0, please use script 'npm run devlegacy' || 'npm run buildlegacy'
52+
5053
Previously, <b>Reactime 14.0 and 15.0</b> added the exciting features below:
5154

5255
I. React Router Compatibility <br>
@@ -98,6 +101,11 @@ Try refreshing the application you want to test and refresh the DevTools by clic
98101

99102
Reactime is an open source project, and we’d really appreciate your help with improving user experience. Please create a pull request (or issue) to propose and collaborate on changes to a repository.
100103

104+
### ❓ <b>Node version compatiability</b>
105+
106+
With release of Node v18.12.1(LTS) on 11/4/22, the script has been updated to 'npm run dev' | 'npm run build' for backwards compatibility.<br/>
107+
For version Node v16.16.0, please use script 'npm run devlegacy' | 'npm run buildlegacy'
108+
101109
## <b>Features</b>
102110

103111
### 🔹 Viewing

package.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,10 @@
1414
]
1515
},
1616
"scripts": {
17-
"build": "webpack --mode production",
18-
"dev": "webpack --mode development --watch",
17+
"build": "NODE_OPTIONS=--openssl-legacy-provider webpack --mode production",
18+
"dev": "NODE_OPTIONS=--openssl-legacy-provider webpack --mode development --watch",
19+
"buildlegacy": "webpack --mode production",
20+
"devlegacy": "webpack --mode development --watch",
1921
"test": "jest --verbose --coverage",
2022
"test-on": "./node_modules/.bin/jest $1",
2123
"docker-test-lint": "eslint --ext .js --ext .jsx src",

src/README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@
33
## Brief
44
Our mission at Reactime is to maintain and iterate constantly, but never at the expense of future developers.<br />We know how hard it is to quickly get up to speed and onboard in a new codebase.<br />So, here are some helpful pointers to help you hit the ground running. 🏃🏾💨
55

6+
<b>With release of Node v18.12.1 (LTS) on 11/4/22, the script has been updated to 'npm run dev' || 'npm run build' for backwards compatibility.<br/>
7+
For version Node v16.16.0, please use script 'npm run devlegacy' || 'npm run buildlegacy'</b>
8+
69
## Quick Tips
710
- _Before_ beginning development, especially on teams, make sure to configure your linter and code formatting to conform to one unified setting (We recommend [the Airbnb style guide](https://github.com/airbnb/javascript)!) This will make reviewing PRs much more readable and less error-prone.
811

src/extension/build/manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "Reactime",
3-
"version": "15.0.0",
3+
"version": "16.0.0",
44
"devtools_page": "devtools.html",
55
"description": "A Chrome extension that helps debug React applications by memorizing the state of components with every render.",
66
"manifest_version": 3,

0 commit comments

Comments
 (0)