Merge pull request #64 from oslabs-beta/ctstamper/Fixing-WebMetrics

ctstamper · web-flow · commit bce6d7eca55b · 2023-10-24T20:08:14.000-07:00
Fixed warning showing in Web Metrics when it shouldn't
diff --git a/src/app/components/StateRoute/StateRoute.tsx b/src/app/components/StateRoute/StateRoute.tsx
@@ -192,7 +192,7 @@ const StateRoute = (props: StateRouteProps) => {
             typeof webMetrics.INP !== 'number' ? '- ms' : `${webMetrics.INP.toFixed(2)} ms`
           }
           score={['200 ms', '500 ms']}
-          overLimit={webMetrics.LCP > 700}
+          overLimit={webMetrics.INP > 700}
           label='Interaction to Next Paint'
           name='Interaction to Next Paint'
           description={`Assesses a page's overall responsiveness to user interactions by observing the latency of all click, tap, and keyboard interactions that occur throughout the lifespan of a user's visit to a page`}

Original file line number	Diff line number	Diff line change
`@@ -192,7 +192,7 @@ const StateRoute = (props: StateRouteProps) => {`
`192`	`192`	typeof webMetrics.INP !== 'number' ? '- ms' : `${webMetrics.INP.toFixed(2)} ms`
`193`	`193`	`}`
`194`	`194`	`score={['200 ms', '500 ms']}`
`195`		`- overLimit={webMetrics.LCP > 700}`
	`195`	`+ overLimit={webMetrics.INP > 700}`
`196`	`196`	`label='Interaction to Next Paint'`
`197`	`197`	`name='Interaction to Next Paint'`
`198`	`198`	description={`Assesses a page's overall responsiveness to user interactions by observing the latency of all click, tap, and keyboard interactions that occur throughout the lifespan of a user's visit to a page`}