Skip to content

Commit c33faae

Browse files
committed
color edits for collapse, toggle record, and performance bar graphs
1 parent 35082ac commit c33faae

File tree

9 files changed

+34
-21
lines changed

9 files changed

+34
-21
lines changed

src/app/components/StateRoute/PerformanceVisx/BarGraph.tsx

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,9 @@ const margin = {
2626
bottom: 0,
2727
left: 50,
2828
};
29-
const axisColor = '#F00008';
29+
const axisColor = '#161617';
30+
const axisTickLabelColor = '#363638';
31+
const axisLabelColor = '#363638';
3032
const background = '#242529';
3133
const tooltipStyles = {
3234
...defaultStyles,
@@ -260,42 +262,44 @@ const BarGraph = (props: BarGraphProps): JSX.Element => {
260262
</BarStack>
261263
</Group>
262264
<AxisLeft
265+
className="BarGraphAxis"
263266
top={margin.top}
264267
left={margin.left}
265268
scale={renderingScale}
266269
stroke={axisColor}
267270
tickStroke={axisColor}
268271
strokeWidth={2}
269272
tickLabelProps={() => ({
270-
fill: 'rgb(231, 231, 231)',
273+
fill: axisTickLabelColor,
271274
fontSize: 11,
272275
verticalAnchor: 'middle',
273276
textAnchor: 'end',
274277
})}
275278
/>
276279
<AxisBottom
280+
className="BarGraphAxis"
277281
top={yMax + margin.top}
278282
left={margin.left}
279283
scale={snapshotIdScale}
280284
stroke={axisColor}
281285
tickStroke={axisColor}
282286
strokeWidth={2}
283287
tickLabelProps={() => ({
284-
fill: 'rgb(231, 231, 231)',
288+
fill: axisTickLabelColor,
285289
fontSize: 11,
286290
textAnchor: 'middle',
287291
})}
288292
/>
289-
<Text x={-yMax / 2 - 75} y='15' transform='rotate(-90)' fontSize={16} fill='#FFFFFF'>
293+
<Text x={-yMax / 2 - 75} y='15' transform='rotate(-90)' fontSize={16} fill={axisLabelColor}>
290294
Rendering Time (ms)
291295
</Text>
292296
<br />
293297
{snapshot === 'All Snapshots' ? (
294-
<Text x={xMax / 2 + 15} y={yMax + 70} fontSize={16} fill='#FFFFFF'>
298+
<Text x={xMax / 2 + 15} y={yMax + 70} fontSize={16} fill={axisLabelColor}>
295299
Snapshot ID
296300
</Text>
297301
) : (
298-
<Text x={xMax / 2 + 15} y={yMax + 70} fontSize={16} fill='#FFFFFF'>
302+
<Text x={xMax / 2 + 15} y={yMax + 70} fontSize={16} fill={axisLabelColor}>
299303
Components
300304
</Text>
301305
)}

src/app/components/StateRoute/PerformanceVisx/BarGraphComparison.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ const margin: Margin = {
3333
bottom: 0,
3434
left: 50,
3535
};
36-
const axisColor = '#62d6fb';
36+
const axisColor = '#ff0000'; //#62d6fb
3737
const background = '#242529';
3838
const tooltipStyles = {
3939
...defaultStyles,

src/app/components/StateRoute/PerformanceVisx/BarGraphComparisonActions.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ const margin: Margin = {
2525
bottom: 0,
2626
left: 50,
2727
};
28-
const axisColor = '#62d6fb';
28+
const axisColor = '#ff0000'; //#62d6fb
2929
const background = '#242529';
3030
const tooltipStyles = {
3131
...defaultStyles,
@@ -274,6 +274,7 @@ const BarGraphComparisonActions = (props: BarGraphComparisonAction) => {
274274
{/* Insert Action Comparison Barstack here */}
275275
</Group>
276276
<AxisLeft
277+
//className="perf-axis"
277278
top={margin.top}
278279
left={margin.left}
279280
scale={renderingScale}

src/app/containers/ActionContainer.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ function ActionContainer(props: ActionContainerProps): JSX.Element {
199199
</div>
200200
<a type='button' id='recordBtn' onClick={toggleRecord}>
201201
<i />
202-
<div style={{ display: 'flex', alignItems: 'center', textAlign: 'right' }}>
202+
<div className="toggle-record" style={{ display: 'flex', alignItems: 'center', textAlign: 'right' }}>
203203
Toggle Record
204204
</div>
205205
{recordingActions ? <Switch defaultChecked /> : <Switch />}

src/app/styles/abstracts/_variablesLM.scss

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,11 @@ $launch-button: $primary-color-strong;
4747
$launch-button-hover: $primary-color;
4848
$launch-button-text: $light-text;
4949

50+
//Collapse and Toggle Record labels
51+
$collapse-text: $dark-text;
52+
$toggle-record-text: $dark-text;
53+
54+
5055
//drop-down menu for selecting which tab Reactime is observing
5156
$tab-select-background: $primary-color;
5257
$tab-select-background-2: $primary-color;
@@ -114,7 +119,8 @@ $performance-options-dropdown: $primary-color-strong;
114119
$performance-options-label: $dark-text;
115120
$performance-save-series-button: $primary-color;
116121
$performance-save-series-button-text: $light-text;
117-
$perf-background: $background-color;
122+
$perf-background: $background-color-strong;
123+
//axis tick colors and labels determined in BarGraph.tsx on line 29
118124

119125
$history-node: $primary-color; //this is currently set in History.tsx line 291
120126
$history-link: $contrasting-color; // this is currently set in d3graph.css line 26

src/app/styles/components/_buttons.scss

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,7 @@
306306

307307
/* sidebar button open and closing functionality */
308308
aside {
309-
background: #242529;
309+
//background: #242529;
310310
color: #fff;
311311
transition: width 1s;
312312
width: 100%; //JR
@@ -319,10 +319,10 @@ aside {
319319

320320
//JR added for collapse label
321321
.collapse {
322+
color: $collapse-text;
322323
display: flex;
323324
align-items: center;
324325
justify-content: flex-start;
325-
background: #242529;
326326
}
327327

328328
.hidden {
@@ -360,7 +360,7 @@ aside {
360360
}
361361

362362
.toggle i::before {
363-
top: -5px;
363+
top: -6px;
364364
}
365365

366366
.toggle i::after {

src/app/styles/layout/_actionContainer.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,3 +39,7 @@
3939
padding-top: 5px;
4040
padding-bottom: 5px;
4141
}
42+
43+
.toggle-record {
44+
color: $toggle-record-text;
45+
}

src/app/styles/layout/_headContainer.scss

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
}
2222

2323
div .tab-select-container {
24-
background-color: #ff0002;
24+
//background-color: #ff0002;
2525
font-size: 14px;
2626
height: 40px;
2727
width: 100%;
@@ -35,18 +35,12 @@ div .tab-select-container {
3535
}
3636

3737
.tab-select-container:active {
38-
background-color: #ff0005;
39-
4038
outline: none;
4139
border-color: transparent;
4240
}
4341

44-
// svg {
45-
// color: #58c1e2;
46-
// }
47-
4842
.tab-select-container {
49-
background-color: #ff0004;
43+
//background-color: #ff0004;
5044
height: 70%;
5145

5246
.tab-select__control:focus {

src/app/styles/layout/_stateContainer.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -215,6 +215,10 @@
215215
margin-top: 1rem;
216216
}
217217

218+
.bar-graph-axis {
219+
stroke: cornflowerblue;
220+
}
221+
218222
#hover-box {
219223
max-width: 230px;
220224
background-color: #51565e;

0 commit comments

Comments
 (0)