Merge pull request #97 from oslabs-beta/rydang/testing

linting packages now

Author: mylee1995

package.json

@@ -8,7 +8,7 @@
     "lint": "eslint --ext .js --ext .jsx src",
     "docker-build": "docker build -t reacttt/test-lint .",
     "docker-check": "docker-compose up --abort-on-container-exit",
-    "docker-test-lint": "eslint --ext .js --ext .jsx src && jest --verbose"
+    "docker-test-lint": "eslint --ext .js --ext .jsx src package && jest --verbose"
   },
   "keywords": [
     "react",

package/__tests__/index.test.js

@@ -11,7 +11,7 @@ describe('unit testing for index.js', () => {
     expect(typeof index).toBe('function');
   });
 
-  test('index.js should be calling timeJump for every jumpToSnap message', (done) => {
+  test('index.js should be calling timeJump for every jumpToSnap message', done => {
     const calls = 10;
     let count = 0;
     global.addEventListener('message', ({ data: { action } }) => {

package/__tests__/linkFiber.test.js

@@ -1,5 +1,4 @@
-/* eslint-disable import/no-extraneous-dependencies */
-// const Tree = require('./tree');
+/* eslint-disable react/jsx-filename-extension */
 import React from 'react';
 import { render } from 'react-dom';
 
@@ -8,7 +7,18 @@ const linkFiberRequire = require('../linkFiber');
 let linkFiber;
 let mode;
 let snapShot;
-let component;
+
+class App extends React.Component {
+  constructor(props) {
+    super(props);
+    this.state = { foo: 'bar' };
+  }
+
+  render() {
+    const { foo } = this.state;
+    return <div>{foo}</div>;
+  }
+}
 
 describe('unit test for linkFiber', () => {
   beforeEach(() => {
@@ -20,22 +30,9 @@ describe('unit test for linkFiber', () => {
     };
     linkFiber = linkFiberRequire(snapShot, mode);
 
-    class App extends React.Component {
-      constructor(props) {
-        super(props);
-        this.state = { foo: 'bar' };
-      }
-
-      render() {
-        return <div>{this.state.foo}</div>;
-      }
-    }
-
     const container = document.createElement('div');
     render(<App />, container);
     linkFiber(container);
-    // eslint-disable-next-line prefer-destructuring
-    component = snapShot.tree.children[0].component;
   });
 
   test('linkFiber should mutate the snapshot tree property', () => {
@@ -49,10 +46,4 @@ describe('unit test for linkFiber', () => {
   test('linkFiber should modify the setState of the stateful component', () => {
     expect(snapShot.tree.children[0].component.setState.linkFiberChanged).toBe(true);
   });
-
-  // test('newSetState should still setState correctly', () => {
-  //   component.setState({ foo: 'barf' });
-  //   expect(component.state).not.toEqual({ foo: 'bar' });
-  //   expect(component.state).toEqual({ foo: 'barf' });
-  // });
 });

package/linkFiber.js

@@ -1,3 +1,5 @@
+/* eslint-disable no-use-before-define */
+/* eslint-disable no-param-reassign */
 // links component state tree to library
 // changes the setState method to also update our snapshot
 const Tree = require('./tree');
@@ -65,13 +67,13 @@ module.exports = (snap, mode) => {
     snap.tree = createTree(current);
   }
 
-  return (container) => {
+  return container => {
     const {
       _reactRootContainer: { _internalRoot },
       _reactRootContainer,
     } = container;
     // only assign internal root if it actually exists
-    fiberRoot = (_internalRoot) ? _internalRoot : _reactRootContainer;
+    fiberRoot = _internalRoot || _reactRootContainer;
     updateSnapShotTree();
 
     // send the initial snapshot once the content script has started up

package/tree.js

@@ -1,3 +1,5 @@
+/* eslint-disable no-console */
+/* eslint-disable no-param-reassign */
 class Tree {
   constructor(component, useStateInstead = false, name) {
     // special case when component is root