removed lock/unlock logic from backend. NOTE: 'lock/unlock' labeled button is using paused logic.

Co-authored-by: Nkmai <[email protected]>
Co-authored-by: lind-tania <[email protected]>
Co-authored-by: rtviner <[email protected]>
Co-authored-by: caitlinchan23 <[email protected]>

Author: 4 people

src/app/components/PerformanceVisx.tsx

@@ -215,7 +215,7 @@ const PerformanceVisx = (props: BarStackProps) => {
                     key={`bar-stack-${barStack.index}-${bar.index}`}
                     x={bar.x}
                     y={bar.y}
-                    height={bar.height === 0 ? idx + 1 : bar.height}
+                    height={bar.height === 0 ? null : bar.height}
                     width={bar.width}
                     fill={bar.color}
                     /* TIP TOOL EVENT HANDLERS */

src/app/containers/ButtonsContainer.tsx

@@ -55,7 +55,7 @@ function ButtonsContainer() {
   const [{ tabs, currentTab }, dispatch] = useStoreContext();
   const {
     snapshots,
-    mode: { paused, locked, persist },
+    mode: { paused, persist },
   } = tabs[currentTab];
 
   return (
@@ -68,13 +68,6 @@ function ButtonsContainer() {
         {paused? <FontAwesomeIcon icon={faUnlock} /> : <FontAwesomeIcon icon={faLock} />}
 				{paused ? 'Unlock' : 'Lock'}
 			</button>
-			{/* <button
-				className="lock-button"
-				type="button"
-				onClick={() => dispatch(toggleMode('locked'))}
-			>
-				{locked ? 'Unlocked': 'Locked'}
-			</button> */}
 			<button
 				className="persist-button"
 				type="button"

src/app/reducers/mainReducer.js

@@ -185,9 +185,6 @@ export default (state, action) => produce(state, draft => {
         case 'paused':
           actionText = 'setPause';
           break;
-        case 'locked':
-          actionText = 'setLock';
-          break;
         case 'persist':
           actionText = 'setPersist';
           break;

src/app/styles/components/_buttons.scss

@@ -127,7 +127,6 @@
 .import-button,
 .howToUse-button,
 .export-button,
-.lock-button,
 .pause-button,
 .persist-button {
 	@extend %button-shared;
@@ -138,7 +137,6 @@
 .import-button:hover,
 .howToUse-button:hover,
 .export-button:hover,
-.lock-button:hover,
 .pause-button:hover,
 .persist-button:hover {
 	@extend %button-shared;

src/backend/__tests__/linkFiber.test.tsx

@@ -69,7 +69,6 @@ describe('unit test for linkFiber', () => {
     mode = {
       jumping: false,
       paused: false,
-      locked: false,
     };
     linkFiber = linkFiberStart(snapShot, mode);
 

src/backend/index.ts

@@ -24,7 +24,6 @@ const snapShot: Snapshot = {
 const mode: Mode = {
   jumping: false,
   paused: false,
-  locked: false,
 };
 // console.log("linkFiberStart in index.ts:" + linkFiberStart);
 const linkFiber = linkFiberStart(snapShot, mode);
@@ -54,9 +53,6 @@ window.addEventListener('message', ({ data: { action, payload } }: MsgData) => {
       // try to modify workInProgress tree from here
       // window.history.pushState('', '', getRouteURL(payload));
       break;
-    case 'setLock':
-      mode.locked = payload;
-      break;
     case 'setPause':
       mode.paused = payload;
       break;
@@ -72,7 +68,7 @@ window.addEventListener('message', ({ data: { action, payload } }: MsgData) => {
              }
         }
       } else {
-        let element = document.querySelector(`.${payload}`);
+        let element: HTMLElement = document.querySelector(`.${payload}`);
         // console.log("element: ", element);
         if (element !== null) {
           // console.log("element style: ", element.style)
@@ -83,13 +79,13 @@ window.addEventListener('message', ({ data: { action, payload } }: MsgData) => {
     case 'onHoverExit': 
         if(Array.isArray(payload)){ 
         for (let i=0; i<payload.length;i++){
-          let element = document.querySelector(`.${payload}`);
+          let element: HTMLElement = document.querySelector(`.${payload}`);
           if (element !== null) {
             element.style.backgroundColor = ''; 
           }
         }
       } else {
-        let element = document.querySelector(`.${payload}`);
+        let element: HTMLElement = document.querySelector(`.${payload}`);
         // console.log("element style: ", element.style)
         if (element !== null) {
           element.style.backgroundColor = ''; 

src/backend/linkFiber.ts

@@ -14,7 +14,7 @@ import {
 
   //tree
   Snapshot,
-  //jump, pause, lock
+  //jump, pause
   Mode,
   ComponentData,
   // array of state and component
@@ -75,7 +75,7 @@ function getRecoilState(): any {
 /**
  * @method sendSnapshot
  * @param snap The current snapshot
- * @param mode The current mode (i.e. jumping, time-traveling, locked, or paused)
+ * @param mode The current mode (i.e. jumping, time-traveling, or paused)
  * @return Nothing.
  *
  * Middleware: Gets a copy of the current snap.tree and posts a recordSnap message to the window
@@ -109,11 +109,11 @@ function sendSnapshot(snap: Snapshot, mode: Mode): void {
 /**
  * @function updateSnapShotTree
  * @param snap The current snapshot
- * @param mode The current mode (i.e. jumping, time-traveling, locked, or paused)
+ * @param mode The current mode (i.e. jumping, time-traveling, or paused)
  * Middleware: Updates snap object with latest snapshot, using @sendSnapshot
  */
 
- //updating tree depending on current mode on the panel (pause, locked etc) 
+ //updating tree depending on current mode on the panel (pause, etc) 
 function updateSnapShotTree(snap: Snapshot, mode: Mode): void {
   // this is the currently active root fiber(the mutable root of the tree)
 
@@ -486,7 +486,7 @@ function createTree(
 /**
  * @method linkFiber
  * @param snap The current snapshot
- * @param mode The current mode (i.e. jumping, time-traveling, locked, or paused)
+ * @param mode The current mode (i.e. jumping, time-traveling, or paused)
  * @return a function to be invoked by index.js that initiates snapshot monitoring
  * linkFiber contains core module functionality, exported as an anonymous function.
  */

src/backend/timeJump.ts

@@ -8,7 +8,7 @@ import { Console } from 'console';
  * It exports an anonymous
  * @function timeJump
  * @param origin The latest snapshot, linked to the fiber (changes to origin will change app)
- * @param mode The current mode (i.e. jumping, time-traveling, locked, or paused)
+ * @param mode The current mode (i.e. jumping, time-traveling, or paused)
  * @returns A function that takes a target snapshot and a boolean flag checking for firstCall, then invokes `jump` on that target snapshot
  *
  * The target snapshot portrays some past state we want to travel to.

src/backend/types/backendTypes.ts

@@ -12,7 +12,6 @@ export interface Snapshot {
 export interface Mode {
   jumping: boolean;
   paused: boolean;
-  locked: boolean;
 }
 
 export interface SnapshotNode {

src/extension/background.js

@@ -30,7 +30,6 @@ function createTabObj(title) {
 		initialHierarchy: null,
 		mode: {
 			persist: false,
-			locked: false,
 			paused: false,
 			empty: false,
 		},
@@ -162,9 +161,6 @@ chrome.runtime.onConnect.addListener((port) => {
 				// resets currBranch
 				tabsObj[tabId].currBranch = 0;
 				return true;
-			case 'setLock':
-				tabsObj[tabId].mode.locked = payload;
-				break;
 			case 'setPause':
 				tabsObj[tabId].mode.paused = payload;
 				break;
@@ -232,7 +228,6 @@ chrome.runtime.onMessage.addListener((request, sender) => {
 			break;
 		}
 		case 'tabReload': {
-			tabsObj[tabId].mode.locked = false;
 			tabsObj[tabId].mode.paused = false;
 			// dont remove snapshots if persisting
 			if (!persist) {