Skip to content

Commit fa14719

Browse files
committed
Removing console logs and fix some eslint and typescript bug
Co-authored-by: Ozair Ghulam https://github.com/OzairGh Co-authored-by: Christina Or https://github.com/christinaor Co-authored-by: Khanh Bui https://github.com/AndyB909
1 parent a602a22 commit fa14719

18 files changed

+291
-387
lines changed

src/app/components/Action.tsx

Lines changed: 35 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ const Action = (props: ActionProps): JSX.Element => {
5050
sliderIndex,
5151
dispatch,
5252
displayName,
53-
componentName,
5453
componentData,
5554
viewIndex,
5655
isCurrIndex,
@@ -103,46 +102,46 @@ const Action = (props: ActionProps): JSX.Element => {
103102
className={
104103
selected || last ? 'action-component selected' : 'action-component'
105104
}
106-
onClick={() => {
107-
dispatch(changeView(index));
108-
}}
109-
role="presentation"
110-
style={index > sliderIndex ? { color: '#5f6369' } : {}}
111-
tabIndex={index}
112-
>
113-
<ReactHover options={optionsCursorTrueWithMargin}>
114-
<Trigger type="trigger">
115-
<div className="action-component-trigger" style={index > sliderIndex ? { color: '#5f6369' } : {}}>
116-
<div className="action-component-text">
117-
<input key={`ActionInput${displayName}`} type="text" className="actionname" placeholder={`Snapshot: ${displayName}`} />
118-
</div>
119-
<button className="time-button" type="button">
120-
{displayTime}
121-
</button>
122-
{
123-
isCurrIndex ? (
124-
<button
125-
className="current-location"
126-
type="button"
127-
>
128-
Current
129-
</button>
130-
)
131-
: (
105+
onClick={() => {
106+
dispatch(changeView(index));
107+
}}
108+
role="presentation"
109+
style={index > sliderIndex ? { color: '#5f6369' } : {}}
110+
tabIndex={index}
111+
>
112+
<ReactHover options={optionsCursorTrueWithMargin}>
113+
<Trigger type="trigger">
114+
<div className="action-component-trigger" style={index > sliderIndex ? { color: '#5f6369' } : {}}>
115+
<div className="action-component-text">
116+
<input key={`ActionInput${displayName}`} type="text" className="actionname" placeholder={`Snapshot: ${displayName}`} />
117+
</div>
118+
<button className="time-button" type="button">
119+
{displayTime}
120+
</button>
121+
{
122+
isCurrIndex ? (
132123
<button
133-
className="jump-button"
134-
onClick={(e: any): void => {
135-
e.stopPropagation();
136-
dispatch(changeSlider(index));
137-
dispatch(changeView(index));
138-
}}
139-
tabIndex={index}
124+
className="current-location"
140125
type="button"
141126
>
142-
Jump
127+
Current
143128
</button>
144129
)
145-
}
130+
: (
131+
<button
132+
className="jump-button"
133+
onClick={(e: any): void => {
134+
e.stopPropagation();
135+
dispatch(changeSlider(index));
136+
dispatch(changeView(index));
137+
}}
138+
tabIndex={index}
139+
type="button"
140+
>
141+
Jump
142+
</button>
143+
)
144+
}
146145
</div>
147146
</Trigger>
148147
<Hover type="hover" />

src/app/components/App.tsx

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
1-
import React, { useReducer, useState } from 'react';
1+
import React, { useReducer } from 'react';
22
import {
33
MemoryRouter as Router,
4-
Route,
5-
NavLink,
6-
Switch,
7-
useLocation,
84
} from 'react-router-dom';
95
// import { Steps, Hints } from 'intro.js-react';
106
import MainContainer from '../containers/MainContainer';
@@ -13,8 +9,10 @@ import mainReducer from '../reducers/mainReducer.js';
139

1410
// import 'intro.js/introjs.css';
1511

16-
// currentTab is the current active tab within Google Chrome. This is used to decide what tab Reactime should be monitoring. This can be "locked"
17-
// currentTabInApp is the current active tab within Reactime (Map, Performance, History, etc). This is used to determine the proper tutorial to render when How To button is pressed.
12+
// currentTab is the current active tab within Google Chrome.
13+
// This is used to decide what tab Reactime should be monitoring. This can be "locked"
14+
// currentTabInApp is the current active tab within Reactime (Map, Performance, History, etc).
15+
// This is used to determine the proper tutorial to render when How To button is pressed.
1816

1917
const initialState: {
2018
port: null | number,

0 commit comments

Comments
 (0)