Skip to content

Fixing and making easily customizable the "verbosity" of the telemetry scansΒ #41

@bjdooi

Description

@bjdooi

Problem

Currently, the verbosity of the telemetry scans are set to high and they return patterns that match all sorts of "potential requests", meaning that the things we find and return to the user may be an overwhelming amount of false positives.

Baked into the telemetry search function call is a "verbose" option which tries to verify that an actual url is being retrieved from the found "request". However, this verbose function is set to true and is only able to be changed by direct modification of the code. A user should be able to modify this through their settings in VS Code.

Also, the filtering for an actual URL should be improved as it only searches for http/https patterns.

Solution

Adding in this verbosity option as VS Code user setting to give users the choice to reduce the number of possible false positives.

The url parsing could be improved through better manipulation of the AST nodes that get built while looking for potential requests. Although the window for identifying these possible requests was made very wide, it would be helpful to better highlight the easy to catch, low hanging fruit.

Additional information

There are other places in the code where we should make things user settings

πŸ‘¨β€πŸ‘§β€πŸ‘¦ Contributing

  • πŸ™‹β€β™‚οΈ Yes, I'd love to make a PR to implement this feature!

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions