Add Playwright for visual testing #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace Puppeteer with Playwright (Next.js recommended) - Create test files for homepage, visual tests, and API routes - Add GitHub workflow for running tests in CI - Update README.md with testing instructions - Update CLAUDE.md with testing commands - Add data-testid attributes to components for easier testing - Update PostCSS config for compatibility with newer Tailwind
✅ Deploy Preview for otelchangelog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
- Update visual tests to be more tolerant of differences - Add threshold parameter to screenshot comparisons - Add updateSnapshots flag to CI workflow - Make API tests more flexible to handle different environments - Improve Playwright configuration for CI environments
- Ignore test-results directory - Ignore playwright-report directory - Ignore playwright cache - Ignore test snapshots
trask
approved these changes
Apr 21, 2025
Member
trask
left a comment
trask
left a comment
There was a problem hiding this comment.
nice, what checks should we make required in this repo?
Member
Author
not sure about the playwright checks but i'm gonna make some followup prs to add unit tests/format ones i think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds visual regression testing using Playwright, as recommended by Next.js.
Key changes:
Follows Test-Driven Development practices by providing automated tests for future changes.