remove unused preferences class (#1200)

Author: fractalwrench

.gitignore

@@ -4,3 +4,4 @@
 demo-app/local.properties
 .DS_Store
 **/build/
+.kotlin/

core/src/test/java/io/opentelemetry/android/OpenTelemetryRumBuilderTest.java

@@ -36,7 +36,6 @@
 import io.opentelemetry.android.instrumentation.internal.AndroidInstrumentationLoaderImpl;
 import io.opentelemetry.android.internal.initialization.InitializationEvents;
 import io.opentelemetry.android.internal.services.CacheStorage;
-import io.opentelemetry.android.internal.services.Preferences;
 import io.opentelemetry.android.internal.services.Services;
 import io.opentelemetry.android.internal.services.applifecycle.AppLifecycle;
 import io.opentelemetry.android.internal.services.visiblescreen.VisibleScreenTracker;
@@ -513,7 +512,6 @@ private static Services createAndSetServiceManager() {
         Services services = mock(Services.class);
         when(services.getAppLifecycle()).thenReturn(mock(AppLifecycle.class));
         when(services.getCacheStorage()).thenReturn(mock(CacheStorage.class));
-        when(services.getPreferences()).thenReturn(mock(Preferences.class));
         VisibleScreenTracker screenService = mock(VisibleScreenTracker.class);
         when(screenService.getCurrentlyVisibleScreen()).thenReturn(CUR_SCREEN_NAME);
         when(services.getVisibleScreenTracker()).thenReturn(screenService);

services/api/services.api

@@ -3,19 +3,13 @@ public class io/opentelemetry/android/internal/services/CacheStorage {
 	public fun getCacheDir ()Ljava/io/File;
 }
 
-public final class io/opentelemetry/android/internal/services/Preferences {
-	public final fun retrieveInt (Ljava/lang/String;I)I
-	public final fun store (Ljava/lang/String;I)V
-}
-
 public final class io/opentelemetry/android/internal/services/Services {
 	public static final field Companion Lio/opentelemetry/android/internal/services/Services$Companion;
 	public static final fun get (Landroid/app/Application;)Lio/opentelemetry/android/internal/services/Services;
 	public final fun getAppLifecycle ()Lio/opentelemetry/android/internal/services/applifecycle/AppLifecycle;
 	public final fun getCacheStorage ()Lio/opentelemetry/android/internal/services/CacheStorage;
 	public final fun getCurrentNetworkProvider ()Lio/opentelemetry/android/internal/services/network/CurrentNetworkProvider;
 	public final fun getPeriodicWork ()Lio/opentelemetry/android/internal/services/periodicwork/PeriodicWork;
-	public final fun getPreferences ()Lio/opentelemetry/android/internal/services/Preferences;
 	public final fun getVisibleScreenTracker ()Lio/opentelemetry/android/internal/services/visiblescreen/VisibleScreenTracker;
 	public static final fun set (Lio/opentelemetry/android/internal/services/Services;)V
 }

services/src/main/java/io/opentelemetry/android/internal/services/Preferences.kt

@@ -22,10 +22,6 @@ import io.opentelemetry.android.internal.services.visiblescreen.VisibleScreenTra
 class Services internal constructor(
     private val factory: ServicesFactory,
 ) {
-    val preferences: Preferences by lazy {
-        factory.createPreferences()
-    }
-
     val cacheStorage: CacheStorage by lazy {
         factory.createCacheStorage()
     }
@@ -68,14 +64,6 @@ class Services internal constructor(
     internal class ServicesFactory(
         private val application: Application,
     ) {
-        fun createPreferences(): Preferences =
-            Preferences(
-                application.getSharedPreferences(
-                    "io.opentelemetry.android" + ".prefs",
-                    Context.MODE_PRIVATE,
-                ),
-            )
-
         fun createCacheStorage(): CacheStorage = CacheStorage(application)
 
         fun createPeriodicWork(): PeriodicWork = PeriodicWork()

services/src/main/java/io/opentelemetry/android/internal/services/Services.kt

@@ -24,8 +24,6 @@ class ServicesTest {
     @Test
     fun `Verify that services are created lazily`() {
         val factory = mockk<ServicesFactory>()
-        val preferences = mockk<Preferences>()
-        every { factory.createPreferences() }.returns(preferences)
         val cacheStorage = mockk<CacheStorage>()
         every { factory.createCacheStorage() }.returns(cacheStorage)
         val periodicWork = mockk<PeriodicWork>()
@@ -41,7 +39,6 @@ class ServicesTest {
         val services = Services(factory)
         verify { factory wasNot Called }
 
-        verifyLazyCreation(preferences, services::preferences, factory::createPreferences)
         verifyLazyCreation(cacheStorage, services::cacheStorage, factory::createCacheStorage)
         verifyLazyCreation(periodicWork, services::periodicWork, factory::createPeriodicWork)
         verifyLazyCreation(