Testbed data race warning at go test with race detection

[james-ryans]

Hi, I’m planning to use testbed to test our e2e with go test -race but sometimes it fails due to data race. Is there a way to avoid this? Or perhaps testbed should not be run with data race detection?

bash -c "set -e; set -o pipefail; GOCACHE=/Users/james_ryans/go/src/github.com/james-ryans/jaeger/.gocache go test -race -v -coverpkg=./... -coverprofile cover.out ./cmd/jaeger/integration/... | sed 's/PASS/✅ PASS/g' | sed 's/FAIL/❌ FAIL/g' | sed 's/SKIP/☠️ SKIP/g'"
?   	github.com/jaegertracing/jaeger/cmd/jaeger/integration/datareceivers	[no test files]
=== RUN   TestKafkaStorage
2024/01/04 15:23:23 Starting mock backend...
2024/01/04 15:23:26  | Sent:         0 items | Received:         0 items (0/sec)
2024-01-04T15:23:29.539+0700	info	service/telemetry.go:86	Setting up own telemetry...
==================
WARNING: DATA RACE
Read at 0x00c0005a9910 by goroutine 19:
  github.com/open-telemetry/opentelemetry-collector-contrib/testbed/testbed.(*MockBackend).GetStats()
      /Users/james_ryans/go/src/github.com/james-ryans/jaeger/vendor/github.com/open-telemetry/opentelemetry-collector-contrib/testbed/testbed/mock_backend.go:132 +0x4d
  github.com/open-telemetry/opentelemetry-collector-contrib/testbed/testbed.(*TestCase).logStatsOnce()
      /Users/james_ryans/go/src/github.com/james-ryans/jaeger/vendor/github.com/open-telemetry/opentelemetry-collector-contrib/testbed/testbed/test_case.go:323 +0xc4
  github.com/open-telemetry/opentelemetry-collector-contrib/testbed/testbed.(*TestCase).logStats()
      /Users/james_ryans/go/src/github.com/james-ryans/jaeger/vendor/github.com/open-telemetry/opentelemetry-collector-contrib/testbed/testbed/test_case.go:312 +0xd1
  github.com/open-telemetry/opentelemetry-collector-contrib/testbed/testbed.NewTestCase.func3()
      /Users/james_ryans/go/src/github.com/james-ryans/jaeger/vendor/github.com/open-telemetry/opentelemetry-collector-contrib/testbed/testbed/test_case.go:120 +0x39

Previous write at 0x00c0005a9910 by goroutine 18:
  github.com/open-telemetry/opentelemetry-collector-contrib/testbed/testbed.(*MockBackend).Start()
      /Users/james_ryans/go/src/github.com/james-ryans/jaeger/vendor/github.com/open-telemetry/opentelemetry-collector-contrib/testbed/testbed/mock_backend.go:101 +0x1f5
  github.com/open-telemetry/opentelemetry-collector-contrib/testbed/testbed.(*TestCase).StartBackend()
      /Users/james_ryans/go/src/github.com/james-ryans/jaeger/vendor/github.com/open-telemetry/opentelemetry-collector-contrib/testbed/testbed/test_case.go:191 +0x47
  github.com/jaegertracing/jaeger/cmd/jaeger/integration.TestKafkaStorage()
      /Users/james_ryans/go/src/github.com/james-ryans/jaeger/cmd/jaeger/integration/kafka_test.go:79 +0xc76
  testing.tRunner()
      /usr/local/Cellar/go/1.20.3/libexec/src/testing/testing.go:1576 +0x216
  testing.(*T).Run.func1()
      /usr/local/Cellar/go/1.20.3/libexec/src/testing/testing.go:1629 +0x47

[yurishkuro]

Looks like startedAt needs to be atomic

[james-ryans]

This issue has been fixed and merged at PR #30549