[pkg/ottl] Add PSliceGetSetter and StandardPSliceGetSetter #44556
+232
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcams
requested review from
a team,
TylerHelmuth,
edmocosta and
evan-bradley
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
PSliceGetSetterinterface andStandardPSliceGetSetterto improve type-safety in OTTL functions.ottl.GetSetter[K]is actually used to handle different slice types in OTTL functions input attributes, but it does not handle all possible slice types we can get on this editor. With this new data type we wouldn't need to handle all those variances in the function's code, avoiding repetitive switches/transformations.Link to tracking issue
Fixes #44421
Testing
Included unit and functional tests.