Skip to content

[processor/redaction] Add system-aware database sanitization to avoid issues with span names #44577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[processor/redaction] Add system-aware database sanitization to avoid issues with span names #44577

wants to merge 1 commit into from

Conversation

@iblancasa
Copy link
Contributor

@iblancasa iblancasa commented Nov 27, 2025 •
edited
Loading

Description

  • Database sanitization now routes to the correct obfuscator based on db.system.name or db.system attribute
  • Added new logic to help detecting URL names and database queries in span names
  • Moved some logic to their own files to help with code readability
  • Remediated situations where the span name resulted in empty string, * or ...

Note this is also related to #43779. After that change, enabling all the db sanitization statements can break span names (they can become ...).

Link to tracking issue

Fixes #44229

Testing

  • Added comprehensive test coverage for the different URL + database combinations

Documentation

  • Updated README with behavior documentation

@iblancasa iblancasa added bug Something isn't working processor/redaction Redaction processor labels Nov 27, 2025
@iblancasa iblancasa changed the title Add system-aware database sanitization to avoid issues with span names [processor/redaction] Add system-aware database sanitization to avoid issues with span names Nov 27, 2025
@iblancasa iblancasa marked this pull request as ready for review November 27, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi is a code owner

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth TylerHelmuth is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@dashpole dashpole

Labels

bug Something isn't working processor/redaction Redaction processor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Database Sanitization is Overly Aggressive

2 participants

@iblancasa @dashpole