Skip to content

Commit dec435a

Browse files
authored
[chore] pin version for npm tooling (#10905)
The repo uses markdown-link-check and not having a package.json file to pin the version causes dependabot security checks sadness. Following the same pattern as the specification repo for storing package.json in the root of the repo. --------- Signed-off-by: Alex Boten <[email protected]>
1 parent abed3ab commit dec435a

File tree

4 files changed

+15
-5
lines changed

4 files changed

+15
-5
lines changed

.github/workflows/changelog.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,10 +77,10 @@ jobs:
7777
- name: Render .chloggen changelog entries
7878
run: make chlog-preview > changelog_preview.md
7979
- name: Install markdown-link-check
80-
run: npm install -g markdown-link-check
80+
run: npm install
8181
- name: Run markdown-link-check
8282
run: |
83-
markdown-link-check \
83+
npx --no -- markdown-link-check \
8484
--verbose \
8585
--config .github/workflows/check_links_config.json \
8686
changelog_preview.md \

.github/workflows/check-links.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: check-links
22
on:
33
push:
4-
branches: [ main ]
4+
branches: [main]
55
pull_request:
66

77
concurrency:
@@ -39,11 +39,11 @@ jobs:
3939
fetch-depth: 0
4040

4141
- name: Install markdown-link-check
42-
run: npm install -g [email protected]
42+
run: npm install
4343

4444
- name: Run markdown-link-check
4545
run: |
46-
markdown-link-check \
46+
npx --no -- markdown-link-check \
4747
--verbose \
4848
--config .github/workflows/check_links_config.json \
4949
${{needs.changedfiles.outputs.md}} \

.gitignore

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,3 +31,8 @@ benchmarks.txt
3131

3232
# golang
3333
go.work*
34+
35+
# npm (used for markdown-link-check)
36+
node_modules/*
37+
package-lock.json
38+

package.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{
2+
"devDependencies": {
3+
"markdown-link-check": "^3.11.2"
4+
}
5+
}

0 commit comments

Comments
 (0)