[chore] Fix test usage of featuregate where errors are not checked (#13214)

Signed-off-by: Bogdan Drutu <[email protected]>

Author: bogdandrutu

config/confighttp/compression_test.go

@@ -152,7 +152,7 @@ func TestHTTPClientCompression(t *testing.T) {
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			_ = featuregate.GlobalRegistry().Set(enableFramedSnappy.ID(), tt.framedSnappyEnabled)
+			require.NoError(t, featuregate.GlobalRegistry().Set(enableFramedSnappy.ID(), tt.framedSnappyEnabled))
 
 			srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 				body, err := io.ReadAll(r.Body)
@@ -352,7 +352,7 @@ func TestHTTPContentDecompressionHandler(t *testing.T) {
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			_ = featuregate.GlobalRegistry().Set(enableFramedSnappy.ID(), tt.framedSnappyEnabled)
+			require.NoError(t, featuregate.GlobalRegistry().Set(enableFramedSnappy.ID(), tt.framedSnappyEnabled))
 
 			srv := httptest.NewServer(httpContentDecompressor(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 				body, err := io.ReadAll(r.Body)
@@ -523,7 +523,7 @@ func TestDecompressorAvoidDecompressionBomb(t *testing.T) {
 	} {
 		t.Run(tc.name, func(t *testing.T) {
 			// t.Parallel() // TODO: Re-enable parallel tests once feature gate is removed. We can't parallelize since registry is shared.
-			_ = featuregate.GlobalRegistry().Set(enableFramedSnappy.ID(), tc.framedSnappyEnabled)
+			require.NoError(t, featuregate.GlobalRegistry().Set(enableFramedSnappy.ID(), tc.framedSnappyEnabled))
 
 			h := httpContentDecompressor(
 				http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {

otelcol/command_print_test.go

@@ -71,17 +71,16 @@ func TestPrintCommand(t *testing.T) {
 	}
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
-			err := featuregate.GlobalRegistry().Set(printCommandFeatureFlag.ID(), true)
-			require.NoError(t, err)
+			require.NoError(t, featuregate.GlobalRegistry().Set(printCommandFeatureFlag.ID(), true))
 			defer func() {
-				_ = featuregate.GlobalRegistry().Set(printCommandFeatureFlag.ID(), false)
+				require.NoError(t, featuregate.GlobalRegistry().Set(printCommandFeatureFlag.ID(), false))
 			}()
 
 			set := ConfigProviderSettings{
 				ResolverSettings: test.set,
 			}
 			cmd := newConfigPrintSubCommand(CollectorSettings{ConfigProviderSettings: set}, flags(featuregate.GlobalRegistry()))
-			err = cmd.Execute()
+			err := cmd.Execute()
 			if test.errString != "" {
 				require.ErrorContains(t, err, test.errString)
 			} else {
@@ -132,10 +131,9 @@ func TestConfig(t *testing.T) {
 	}
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
-			err := featuregate.GlobalRegistry().Set(printCommandFeatureFlag.ID(), true)
-			require.NoError(t, err)
+			require.NoError(t, featuregate.GlobalRegistry().Set(printCommandFeatureFlag.ID(), true))
 			defer func() {
-				_ = featuregate.GlobalRegistry().Set(printCommandFeatureFlag.ID(), false)
+				require.NoError(t, featuregate.GlobalRegistry().Set(printCommandFeatureFlag.ID(), false))
 			}()
 			set := ConfigProviderSettings{
 				ResolverSettings: confmap.ResolverSettings{

service/pipelines/config_test.go

@@ -113,8 +113,7 @@ func TestNoPipelinesFeatureGate(t *testing.T) {
 	require.Error(t, xconfmap.Validate(cfg))
 
 	gate := AllowNoPipelines
-	err := featuregate.GlobalRegistry().Set(gate.ID(), true)
-	require.NoError(t, err)
+	require.NoError(t, featuregate.GlobalRegistry().Set(gate.ID(), true))
 	defer func() {
 		require.NoError(t, featuregate.GlobalRegistry().Set(gate.ID(), false))
 	}()