Skip to content

Conversation

@paulojmdias
Copy link
Member

Description

This PR ensures we use the same modernize package as golanglint

@paulojmdias paulojmdias requested a review from a team as a code owner November 17, 2025 21:23
@github-actions github-actions bot added the release:risky-change This change may affect the release label Nov 17, 2025
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.17%. Comparing base (7012862) to head (eead7cf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14175   +/-   ##
=======================================
  Coverage   92.16%   92.17%           
=======================================
  Files         668      668           
  Lines       41463    41463           
=======================================
+ Hits        38216    38217    +1     
+ Misses       2214     2213    -1     
  Partials     1033     1033           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…s/opentelemetry-collector into chore/use_golanglint_analyzer

Signed-off-by: Paulo Dias <[email protected]>
Signed-off-by: Paulo Dias <[email protected]>
Copy link
Member

@dmathieu dmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working locally.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 28, 2025

CodSpeed Performance Report

Merging #14175 will degrade performances by 33.67%

Comparing paulojmdias:chore/use_golanglint_analyzer (eead7cf) with main (7012862)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

⚡ 1 improvement
❌ 1 regression
✅ 71 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
zstdWithConcurrency 19 µs 28.7 µs -33.67%
BenchmarkSplittingBasedOnItemCountManySmallLogs 3.3 ms 2.4 ms +36.07%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:risky-change This change may affect the release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants