-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[chore] use the same modernize as golanglint #14175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[chore] use the same modernize as golanglint #14175
Conversation
Signed-off-by: Paulo Dias <[email protected]>
Signed-off-by: Paulo Dias <[email protected]>
Signed-off-by: Paulo Dias <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14175 +/- ##
=======================================
Coverage 92.16% 92.17%
=======================================
Files 668 668
Lines 41463 41463
=======================================
+ Hits 38216 38217 +1
+ Misses 2214 2213 -1
Partials 1033 1033 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Paulo Dias <[email protected]>
…s/opentelemetry-collector into chore/use_golanglint_analyzer Signed-off-by: Paulo Dias <[email protected]>
Signed-off-by: Paulo Dias <[email protected]>
dmathieu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed working locally.
CodSpeed Performance ReportMerging #14175 will degrade performances by 33.67%Comparing
|
| Benchmark | BASE |
HEAD |
Change | |
|---|---|---|---|---|
| ❌ | zstdWithConcurrency |
19 µs | 28.7 µs | -33.67% |
| ⚡ | BenchmarkSplittingBasedOnItemCountManySmallLogs |
3.3 ms | 2.4 ms | +36.07% |
Signed-off-by: Paulo Dias <[email protected]>
Description
This PR ensures we use the same modernize package as golanglint