Skip to content

[chore] use the same modernize as golanglint #14175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

[chore] use the same modernize as golanglint #14175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3d65388
[chore] use the same modernize as golanglint
paulojmdias Nov 17, 2025
f6b2a33
fix: revert -fix
paulojmdias Nov 17, 2025
ea96fd6
fix: fix -slicessort
paulojmdias Nov 17, 2025
8d64e8e
Merge branch 'main' into chore/use_golanglint_analyzer
paulojmdias Nov 17, 2025
732b1f3
feat: move modernize to internal/tools
paulojmdias Nov 18, 2025
9a7a782
Merge branch 'chore/use_golanglint_analyzer' of github.com:paulojmdia…
paulojmdias Nov 18, 2025
4f76246
chore: update golanglint
paulojmdias Nov 18, 2025
07b894b
Merge branch 'main' into chore/use_golanglint_analyzer
paulojmdias Nov 20, 2025
9b7948a
Merge branch 'main' into chore/use_golanglint_analyzer
paulojmdias Nov 28, 2025
f665983
chore: make gotidy
paulojmdias Nov 28, 2025
eead7cf
Merge branch 'main' into chore/use_golanglint_analyzer
codeboten Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions Makefile.Common
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,16 +50,12 @@ benchmark:
.PHONY: fmt
fmt: common/gofmt common/goimports common/gofumpt

# `modernize' cannot be installed as a Go tool via `go get -tool'.
#
# See [1] for more details.
#
# [1]: https://github.com/golang/go/issues/73279
.PHONY: modernize
modernize:
$(GOCMD) run \
golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest \
-fix -test -v ./...
$(GO_TOOL) modernize \
-fix -test -v -any -bloop -fmtappendf -forvar -mapsloop -minmax -newexpr -omitzero -plusbuild \
-rangeint -reflecttypefor -slicescontains -slicessort -stditerators -stringscut \
-stringscutprefix -stringsseq -stringsbuilder -testingcontext -waitgroup ./...

.PHONY: tidy
tidy:
Expand Down
1 change: 1 addition & 0 deletions internal/tools/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ tool (
go.opentelemetry.io/build-tools/multimod
golang.org/x/exp/cmd/apidiff
golang.org/x/tools/cmd/goimports
golang.org/x/tools/go/analysis/passes/modernize/cmd/modernize
golang.org/x/vuln/cmd/govulncheck
gotest.tools/gotestsum
mvdan.cc/gofumpt
Expand Down
Loading