Skip to content

Commit 8bdab8d

Browse files
authored
[Geneva Metrics] Small fix in example for Geneva metrics exporter (#263)
1 parent 9855e02 commit 8bdab8d

File tree

2 files changed

+47
-1
lines changed

2 files changed

+47
-1
lines changed
Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
name: Geneva Metrics CI
2+
3+
on:
4+
push:
5+
branches: "*"
6+
paths:
7+
- "exporters/geneva/**"
8+
- ".github/workflows/geneva_metrics.yml"
9+
pull_request:
10+
branches: [main]
11+
paths:
12+
- "exporters/geneva/**"
13+
- ".github/workflows/geneva_metrics.yml"
14+
15+
cmake_linux:
16+
name: CMake on Linux
17+
runs-on: ubuntu-latest
18+
steps:
19+
- name: checkout otel contrib geneva metrics
20+
uses: actions/checkout@v3
21+
with:
22+
path: "otel_cpp_contrib"
23+
- name: checkout otel cpp
24+
uses: actions/checkout@v3
25+
with:
26+
repository: "open-telemetry/opentelemetry-cpp"
27+
ref: "v1.8.2"
28+
path: "otel_cpp"
29+
submodules: "recursive"
30+
- name: setup
31+
run: |
32+
sudo apt update -y
33+
sudo apt install -y --no-install-recommends --no-install-suggests build-essential\
34+
ca-certificates wget git valgrind lcov
35+
- name: run tests
36+
run: |
37+
mkdir -p "$GITHUB_WORKSPACE/otel_cpp/build"
38+
cd "$GITHUB_WORKSPACE/otel_cpp/build"
39+
cmake .. -DCMAKE_BUILD_TYPE=Debug
40+
cmake --build . -j --config Debug
41+
cmake --install . --prefix "$HOME/prebuilt-otel" --config Debug
42+
mkdir -p "$GITHUB_WORKSPACE/otel_cpp_contrib/exporters/geneva/build"
43+
cd "$GITHUB_WORKSPACE/otel_cpp_contrib/exporters/geneva/build"
44+
cmake .. "-DCMAKE_PREFIX_PATH=$HOME/prebuilt-otel" -DCMAKE_BUILD_TYPE=Debug \
45+
-DBUILD_TESTING=ON -DBUILD_EXAMPLE=ON
46+
cmake --build . -j --config Debug

exporters/geneva/example/example_metrics.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ void initMetrics(const std::string &name, const std::string &account_name) {
8989
new opentelemetry::sdk::metrics::HistogramAggregationConfig()};
9090
static_cast<opentelemetry::sdk::metrics::HistogramAggregationConfig *>(
9191
aggregation_config.get())
92-
->boundaries_ = std::list<double>{0.0, 50.0, 100.0, 250.0, 500.0,
92+
->boundaries_ = std::vector<double>{0.0, 50.0, 100.0, 250.0, 500.0,
9393
750.0, 1000.0, 2500.0, 5000.0, 10000.0};
9494
std::unique_ptr<metric_sdk::View> histogram_view{new metric_sdk::View{
9595
name, "description", metric_sdk::AggregationType::kHistogram,

0 commit comments

Comments
 (0)