From 68230507473d52f060da23959e717ee6e536fcf0 Mon Sep 17 00:00:00 2001 From: Karthikeya K S S Date: Fri, 3 Oct 2025 16:13:27 +0000 Subject: [PATCH 1/2] resolve socket leak in fluentd exporter --- exporters/fluentd/src/log/fluentd_exporter.cc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/exporters/fluentd/src/log/fluentd_exporter.cc b/exporters/fluentd/src/log/fluentd_exporter.cc index ea6e05f7f..328bc0597 100644 --- a/exporters/fluentd/src/log/fluentd_exporter.cc +++ b/exporters/fluentd/src/log/fluentd_exporter.cc @@ -169,6 +169,11 @@ bool FluentdExporter::Connect() { connected_ = socket_.connect(*addr_); if (!connected_) { LOG_ERROR("Unable to connect to %s", options_.endpoint.c_str()); + // Close the socket to avoid leaking file descriptors on failure. + if (!socket_.invalid()) { + socket_.close(); + } + connected_ = false; return false; } } From 991f0cb21a3b1f38ea4a5e9c6dd1fbdc7a85ec52 Mon Sep 17 00:00:00 2001 From: Karthikeya K S S Date: Fri, 3 Oct 2025 20:21:12 +0000 Subject: [PATCH 2/2] remove unwanted assignments --- exporters/fluentd/src/log/fluentd_exporter.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/exporters/fluentd/src/log/fluentd_exporter.cc b/exporters/fluentd/src/log/fluentd_exporter.cc index 328bc0597..92490c622 100644 --- a/exporters/fluentd/src/log/fluentd_exporter.cc +++ b/exporters/fluentd/src/log/fluentd_exporter.cc @@ -173,7 +173,6 @@ bool FluentdExporter::Connect() { if (!socket_.invalid()) { socket_.close(); } - connected_ = false; return false; } }