address review feedback. Move shared pointers in explicit constructor of HttpSessionData

Author: dbarker

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_client.h

@@ -237,12 +237,10 @@ class OtlpHttpClient
     HttpSessionData() = default;
 
     explicit HttpSessionData(
-        std::shared_ptr<opentelemetry::ext::http::client::Session> input_session,
-        std::shared_ptr<opentelemetry::ext::http::client::EventHandler> input_handle)
-    {
-      session.swap(input_session);
-      event_handle.swap(input_handle);
-    }
+        std::shared_ptr<opentelemetry::ext::http::client::Session> &&input_session,
+        std::shared_ptr<opentelemetry::ext::http::client::EventHandler> &&input_handle)
+        : session(std::move(input_session)), event_handle(std::move(input_handle))
+    {}
   };
 
   /**

exporters/otlp/src/otlp_http_client.cc

@@ -1000,8 +1000,9 @@ OtlpHttpClient::createSession(
 
   // Returns the created session data
   return HttpSessionData{
-      session, std::shared_ptr<opentelemetry::ext::http::client::EventHandler>{
-                   new ResponseHandler(std::move(result_callback), options_.console_debug)}};
+      std::move(session),
+      std::shared_ptr<opentelemetry::ext::http::client::EventHandler>{
+          new ResponseHandler(std::move(result_callback), options_.console_debug)}};
 }
 
 void OtlpHttpClient::addSession(HttpSessionData &&session_data) noexcept