Update test

psx95 · psx95 · commit 178561083081 · 2024-11-05T05:29:12.000Z
diff --git a/api/test/trace/propagation/detail/string_test.cc b/api/test/trace/propagation/detail/string_test.cc
@@ -25,7 +25,6 @@ struct SplitStringTestData
   // See https://github.com/google/googletest/issues/3805.
   friend void PrintTo(const SplitStringTestData &data, std::ostream *os)
   {
-    std::stringstream ss;
     *os << "(" << data.input << "," << data.separator << "," << data.max_count << ","
         << data.expected_number_strings << ")";
   }
@@ -50,8 +49,7 @@ class SplitStringTestFixture : public ::testing::TestWithParam<SplitStringTestDa
 TEST_P(SplitStringTestFixture, SplitsAsExpected)
 {
   const SplitStringTestData test_param = GetParam();
-  std::vector<opentelemetry::nostd::string_view> fields{};
-  fields.reserve(test_param.expected_number_strings);
+  std::vector<opentelemetry::nostd::string_view> fields(test_param.expected_number_strings);
   size_t got_splits_num = opentelemetry::trace::propagation::detail::SplitString(
       test_param.input, test_param.separator, fields.data(), test_param.max_count);
 

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,6 @@ struct SplitStringTestData`
`25`	`25`	`// See https://github.com/google/googletest/issues/3805.`
`26`	`26`	`friend void PrintTo(const SplitStringTestData &data, std::ostream *os)`
`27`	`27`	`{`
`28`		`- std::stringstream ss;`
`29`	`28`	`*os << "(" << data.input << "," << data.separator << "," << data.max_count << ","`
`30`	`29`	`<< data.expected_number_strings << ")";`
`31`	`30`	`}`
`@@ -50,8 +49,7 @@ class SplitStringTestFixture : public ::testing::TestWithParam<SplitStringTestDa`
`50`	`49`	`TEST_P(SplitStringTestFixture, SplitsAsExpected)`
`51`	`50`	`{`
`52`	`51`	`const SplitStringTestData test_param = GetParam();`
`53`		`- std::vector<opentelemetry::nostd::string_view> fields{};`
`54`		`- fields.reserve(test_param.expected_number_strings);`
	`52`	`+ std::vector<opentelemetry::nostd::string_view> fields(test_param.expected_number_strings);`
`55`	`53`	`size_t got_splits_num = opentelemetry::trace::propagation::detail::SplitString(`
`56`	`54`	`test_param.input, test_param.separator, fields.data(), test_param.max_count);`
`57`	`55`