Fix unintialized buffer in copy ctor

chusitoo · chusitoo · commit 207c3e3e49ff · 2024-11-18T18:16:56.000-05:00
diff --git a/api/include/opentelemetry/context/context.h b/api/include/opentelemetry/context/context.h
@@ -135,7 +135,10 @@ class Context
     }
 
     DataList(const DataList &other)
-        : key_length_(other.key_length_), next_(other.next_), value_(other.value_)
+        : key_(new char[other.key_length_]),
+          key_length_(other.key_length_),
+          next_(other.next_),
+          value_(other.value_)
     {
       memcpy(key_, other.key_, other.key_length_ * sizeof(char));
     }

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,10 @@ class Context`
`135`	`135`	`}`
`136`	`136`
`137`	`137`	`DataList(const DataList &other)`
`138`		`- : key_length_(other.key_length_), next_(other.next_), value_(other.value_)`
	`138`	`+ : key_(new char[other.key_length_]),`
	`139`	`+ key_length_(other.key_length_),`
	`140`	`+ next_(other.next_),`
	`141`	`+ value_(other.value_)`
`139`	`142`	`{`
`140`	`143`	`memcpy(key_, other.key_, other.key_length_ * sizeof(char));`
`141`	`144`	`}`