Skip to content

Commit 2332906

Browse files
committed
Remove unused param and minor touchup for assert
1 parent fadff90 commit 2332906

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

ext/test/http/curl_http_test.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -538,7 +538,7 @@ struct GzipEventHandler : public CustomEventHandler
538538
{
539539
~GzipEventHandler() override = default;
540540

541-
void OnResponse(http_client::Response &response) noexcept override {}
541+
void OnResponse(http_client::Response & /* response */) noexcept override {}
542542

543543
void OnEvent(http_client::SessionState state, nostd::string_view reason) noexcept override
544544
{
@@ -575,7 +575,7 @@ TEST_F(BasicCurlHttpTests, GzipCompressibleData)
575575
session->FinishSession();
576576
ASSERT_TRUE(handler->is_called_);
577577
ASSERT_EQ(handler->state_, http_client::SessionState::Response);
578-
ASSERT_EQ(handler->reason_, "");
578+
ASSERT_TRUE(handler->reason_.empty());
579579

580580
auto http_request =
581581
dynamic_cast<opentelemetry::ext::http::client::curl::Request *>(request.get());
@@ -623,7 +623,7 @@ TEST_F(BasicCurlHttpTests, GzipIncompressibleData)
623623
session->FinishSession();
624624
ASSERT_TRUE(handler->is_called_);
625625
ASSERT_EQ(handler->state_, http_client::SessionState::Response);
626-
ASSERT_EQ(handler->reason_, "");
626+
ASSERT_TRUE(handler->reason_.empty());
627627

628628
auto http_request =
629629
dynamic_cast<opentelemetry::ext::http::client::curl::Request *>(request.get());

0 commit comments

Comments
 (0)