[SDK] Implement env var configuration for PeriodicExportingMetricReaderOptions

Author: mathieurobin1

ext/src/dll/input.src

@@ -16,6 +16,7 @@ ForceFlush@LoggerProvider@logs@sdk@v1@opentelemetry
 OStreamLogRecordExporter@logs@exporter@v1@opentelemetry
 Create@OStreamMetricExporterFactory@metrics@exporter@v1@opentelemetry
 Create@PeriodicExportingMetricReaderFactory@metrics@sdk@v1@opentelemetry
+PeriodicExportingMetricReaderOptions@metrics@sdk@v1@opentelemetry
 Create@MeterProviderFactory@metrics@sdk@v1@opentelemetry
 Create@MeterContextFactory@metrics@sdk@v1@opentelemetry
 Create@ViewFactory@metrics@sdk@v1@opentelemetry

sdk/include/opentelemetry/sdk/metrics/export/periodic_exporting_metric_reader_options.h

@@ -5,7 +5,6 @@
 
 #include <chrono>
 
-#include "opentelemetry/nostd/string_view.h"
 #include "opentelemetry/version.h"
 
 OPENTELEMETRY_BEGIN_NAMESPACE
@@ -17,14 +16,11 @@ namespace metrics
 constexpr std::chrono::milliseconds kExportIntervalMillis = std::chrono::milliseconds(60000);
 constexpr std::chrono::milliseconds kExportTimeOutMillis  = std::chrono::milliseconds(30000);
 
-std::chrono::milliseconds GetEnvDuration(nostd::string_view env_var_name,
-                                         std::chrono::milliseconds default_value);
-
 /**
  * Struct to hold PeriodicExortingMetricReader options.
  */
 
-struct PeriodicExportingMetricReaderOptions
+struct OPENTELEMETRY_EXPORT PeriodicExportingMetricReaderOptions
 {
   /* The time interval between two consecutive exports. */
   std::chrono::milliseconds export_interval_millis;

sdk/src/metrics/export/periodic_exporting_metric_reader_options.cc

@@ -24,10 +24,12 @@ std::chrono::milliseconds GetEnvDuration(nostd::string_view env_var_name,
   }
   return default_value;
 }
+
 PeriodicExportingMetricReaderOptions::PeriodicExportingMetricReaderOptions()
     : export_interval_millis(GetEnvDuration("OTEL_METRIC_EXPORT_INTERVAL", kExportIntervalMillis)),
       export_timeout_millis(GetEnvDuration("OTEL_METRIC_EXPORT_TIMEOUT", kExportTimeOutMillis))
 {}
+
 }  // namespace metrics
 }  // namespace sdk
 OPENTELEMETRY_END_NAMESPACE

sdk/test/metrics/periodic_exporting_metric_reader_test.cc

@@ -4,7 +4,9 @@
 #include <gtest/gtest.h>
 #include <stddef.h>
 #include <chrono>
+#include <cstdlib>
 #include <memory>
+#include <ratio>
 #include <thread>
 #include <utility>
 #include <vector>
@@ -18,8 +20,9 @@
 #include "opentelemetry/sdk/metrics/push_metric_exporter.h"
 
 #if defined(_MSC_VER)
-using opentelemetry::common::setenv;
-using opentelemetry::common::unsetenv;
+#  include "opentelemetry/sdk/common/env_variables.h"
+using opentelemetry::sdk::common::setenv;
+using opentelemetry::sdk::common::unsetenv;
 #endif
 
 using namespace opentelemetry;
@@ -114,41 +117,6 @@ TEST(PeriodicExportingMetricReader, Timeout)
   reader->Shutdown();
 }
 
-TEST(GetEnvDurationTest, Absent)
-{
-  const char *env = "OTEL_TEST";
-  unsetenv(env);
-  EXPECT_EQ(GetEnvDuration(env, std::chrono::milliseconds(42)), std::chrono::milliseconds(42));
-}
-
-TEST(GetEnvDurationTest, NotSet)
-{
-  const char *env = "OTEL_TEST";
-  setenv(env, "", 1);
-  EXPECT_EQ(GetEnvDuration(env, std::chrono::milliseconds(42)), std::chrono::milliseconds(42));
-  unsetenv(env);
-}
-
-TEST(GetEnvDurationTest, Valid)
-{
-  const char *env = "OTEL_TEST";
-  setenv(env, "1243ms", 1);
-  EXPECT_EQ(GetEnvDuration(env, std::chrono::milliseconds(42)), std::chrono::milliseconds(1243));
-
-  setenv(env, "3s", 1);
-  EXPECT_EQ(GetEnvDuration(env, std::chrono::milliseconds(42)), std::chrono::milliseconds(3000));
-
-  unsetenv(env);
-}
-
-TEST(GetEnvDurationTest, Invalid)
-{
-  const char *env = "OTEL_TEST";
-  setenv(env, "not_a_duration", 1);
-  EXPECT_EQ(GetEnvDuration(env, std::chrono::milliseconds(42)), std::chrono::milliseconds(42));
-  unsetenv(env);
-}
-
 TEST(PeriodicExportingMetricReaderOptions, UsesEnvVars)
 {
   const char *env_interval = "OTEL_METRIC_EXPORT_INTERVAL";