Merge branch 'main' into link_problems_of_grpc

Author: marcalff

CHANGELOG.md

@@ -15,6 +15,9 @@ Increment the:
 
 ## [Unreleased]
 
+* [BUILD] Error out when building DLL without MSVC
+  [#3438](https://github.com/open-telemetry/opentelemetry-cpp/pull/3438)
+
 * [Metrics SDK] Use nostd::function_ref in AttributesHashMap
   [#3393](https://github.com/open-telemetry/opentelemetry-cpp/pull/3393)
 

cmake/find-package-support-functions.cmake

@@ -140,11 +140,6 @@ function(find_required_dependencies components_in)
     if(is_required)
         message(DEBUG "find_required_dependencies: calling find_dependency(${_dependency} ${OTEL_${_dependency}_SEARCH_MODE} )...")
         find_dependency(${_dependency} ${OTEL_${_dependency}_SEARCH_MODE})
-      if(${_dependency}_FOUND AND DEFINED OTEL_${_dependency}_VERSION AND DEFINED ${_dependency}_VERSION)
-        if(NOT ${_dependency}_VERSION VERSION_EQUAL ${OTEL_${_dependency}_VERSION})
-          message(WARNING "find_required_dependencies: found ${_dependency} version ${${_dependency}_VERSION} which does not match the opentelemetry-cpp built with version ${OTEL_${_dependency}_VERSION}.")
-        endif()
-      endif()
     endif()
   endforeach()
 endfunction()

examples/otlp/CMakeLists.txt

@@ -115,7 +115,7 @@ if(WITH_OTLP_HTTP)
     target_compile_definitions(example_otlp_instrumented_http
                                PRIVATE OPENTELEMETRY_BUILD_IMPORT_DLL)
     target_link_libraries(example_otlp_instrumented_http
-                          opentelemetry-cpp::opentelemetry_cpp)
+                          PRIVATE opentelemetry-cpp::opentelemetry_cpp)
   else()
     target_link_libraries(
       example_otlp_instrumented_http

ext/src/CMakeLists.txt

@@ -5,6 +5,6 @@ if(WITH_HTTP_CLIENT_CURL)
   add_subdirectory(http/client/curl)
 endif()
 
-if(MSVC AND DEFINED OPENTELEMETRY_BUILD_DLL)
+if(DEFINED OPENTELEMETRY_BUILD_DLL)
   add_subdirectory(dll)
 endif()

ext/src/dll/CMakeLists.txt

@@ -1,6 +1,12 @@
 # Copyright The OpenTelemetry Authors
 # SPDX-License-Identifier: Apache-2.0
 
+if(NOT MSVC)
+  message(
+    FATAL_ERROR
+      "The OpenTelemetry C++ SDK for Windows DLL is only supported on MSVC.")
+endif()
+
 set(OPENTELEMETRY_EXPORT_DEF
     "${CMAKE_CURRENT_BINARY_DIR}/opentelemetry_cpp.def")