more clang-tidy cleanup

Author: marcalff

examples/yaml/custom_sampler.h

@@ -17,7 +17,11 @@ class CustomSampler : public opentelemetry::sdk::trace::Sampler
 {
 public:
   CustomSampler(const std::string & /* comment */) {}
-  ~CustomSampler() override = default;
+  CustomSampler(CustomSampler &&)                      = delete;
+  CustomSampler(const CustomSampler &)                 = delete;
+  CustomSampler &operator=(CustomSampler &&)           = delete;
+  CustomSampler &operator=(const CustomSampler &other) = delete;
+  ~CustomSampler() override                            = default;
 
   opentelemetry::sdk::trace::SamplingResult ShouldSample(
       const opentelemetry::trace::SpanContext &parent_context,

examples/yaml/custom_sampler_builder.h

@@ -15,9 +15,6 @@ class CustomSamplerBuilder : public opentelemetry::sdk::init::ExtensionSamplerBu
 public:
   static void Register(opentelemetry::sdk::init::Registry *registry);
 
-  CustomSamplerBuilder()           = default;
-  ~CustomSamplerBuilder() override = default;
-
   std::unique_ptr<opentelemetry::sdk::trace::Sampler> Build(
       const opentelemetry::sdk::configuration::ExtensionSamplerConfiguration *model) const override;
 };

examples/yaml/custom_span_exporter.h

@@ -16,7 +16,11 @@ class CustomSpanExporter : public opentelemetry::sdk::trace::SpanExporter
 {
 public:
   CustomSpanExporter(const std::string & /* comment */) {}
-  ~CustomSpanExporter() override = default;
+  CustomSpanExporter(CustomSpanExporter &&)                      = delete;
+  CustomSpanExporter(const CustomSpanExporter &)                 = delete;
+  CustomSpanExporter &operator=(CustomSpanExporter &&)           = delete;
+  CustomSpanExporter &operator=(const CustomSpanExporter &other) = delete;
+  ~CustomSpanExporter() override                                 = default;
 
   std::unique_ptr<opentelemetry::sdk::trace::Recordable> MakeRecordable() noexcept override;
 

examples/yaml/custom_span_exporter_builder.h

@@ -15,9 +15,6 @@ class CustomSpanExporterBuilder : public opentelemetry::sdk::init::ExtensionSpan
 public:
   static void Register(opentelemetry::sdk::init::Registry *registry);
 
-  CustomSpanExporterBuilder()           = default;
-  ~CustomSpanExporterBuilder() override = default;
-
   std::unique_ptr<opentelemetry::sdk::trace::SpanExporter> Build(
       const opentelemetry::sdk::configuration::ExtensionSpanExporterConfiguration *model)
       const override;

examples/yaml/custom_span_processor.cc

@@ -23,9 +23,10 @@ void CustomSpanProcessor::OnStart(
 }
 
 void CustomSpanProcessor::OnEnd(
-    std::unique_ptr<opentelemetry::sdk::trace::Recordable> && /* span */) noexcept
+    std::unique_ptr<opentelemetry::sdk::trace::Recordable> &&span) noexcept
 {
   OTEL_INTERNAL_LOG_ERROR("CustomSpanProcessor::OnEnd(): FIXME");
+  auto unused = std::move(span);
 }
 
 bool CustomSpanProcessor::ForceFlush(std::chrono::microseconds /* timeout */) noexcept

examples/yaml/custom_span_processor.h

@@ -15,7 +15,11 @@ class CustomSpanProcessor : public opentelemetry::sdk::trace::SpanProcessor
 {
 public:
   CustomSpanProcessor(const std::string &comment) : m_comment(comment) {}
-  ~CustomSpanProcessor() override = default;
+  CustomSpanProcessor(CustomSpanProcessor &&)                      = delete;
+  CustomSpanProcessor(const CustomSpanProcessor &)                 = delete;
+  CustomSpanProcessor &operator=(CustomSpanProcessor &&)           = delete;
+  CustomSpanProcessor &operator=(const CustomSpanProcessor &other) = delete;
+  ~CustomSpanProcessor() override                                  = default;
 
   std::unique_ptr<opentelemetry::sdk::trace::Recordable> MakeRecordable() noexcept override;
 

examples/yaml/custom_span_processor_builder.h

@@ -15,9 +15,6 @@ class CustomSpanProcessorBuilder : public opentelemetry::sdk::init::ExtensionSpa
 public:
   static void Register(opentelemetry::sdk::init::Registry *registry);
 
-  CustomSpanProcessorBuilder()           = default;
-  ~CustomSpanProcessorBuilder() override = default;
-
   std::unique_ptr<opentelemetry::sdk::trace::SpanProcessor> Build(
       const opentelemetry::sdk::configuration::ExtensionSpanProcessorConfiguration *model)
       const override;

examples/yaml/main.cc

@@ -56,7 +56,7 @@
 static bool opt_help              = false;
 static std::string yaml_file_path = "";
 
-std::unique_ptr<opentelemetry::sdk::init::ConfiguredSdk> sdk;
+static std::unique_ptr<opentelemetry::sdk::init::ConfiguredSdk> sdk;
 
 namespace
 {
@@ -138,7 +138,7 @@ void CleanupOtel()
 }
 }  // namespace
 
-void usage(FILE *out)
+static void usage(FILE *out)
 {
   static const char *msg =
       "Usage: example_yaml [options]\n"
@@ -154,7 +154,7 @@ void usage(FILE *out)
   fprintf(out, "%s", msg);
 }
 
-int parse_args(int argc, char *argv[])
+static int parse_args(int argc, char *argv[])
 {
   int remaining_argc    = argc;
   char **remaining_argv = argv;

sdk/test/configuration/yaml_resource_test.cc

@@ -14,7 +14,8 @@
 #include "opentelemetry/sdk/configuration/string_array_configuration.h"
 #include "opentelemetry/sdk/configuration/yaml_configuration_factory.h"
 
-std::unique_ptr<opentelemetry::sdk::configuration::Configuration> DoParse(const std::string &yaml)
+static std::unique_ptr<opentelemetry::sdk::configuration::Configuration> DoParse(
+    const std::string &yaml)
 {
   static const std::string source("test");
   return opentelemetry::sdk::configuration::YamlConfigurationFactory::ParseString(source, yaml);

sdk/test/configuration/yaml_test.cc

@@ -12,7 +12,8 @@
 #include "opentelemetry/sdk/configuration/tracer_provider_configuration.h"
 #include "opentelemetry/sdk/configuration/yaml_configuration_factory.h"
 
-std::unique_ptr<opentelemetry::sdk::configuration::Configuration> DoParse(const std::string &yaml)
+static std::unique_ptr<opentelemetry::sdk::configuration::Configuration> DoParse(
+    const std::string &yaml)
 {
   static const std::string source("test");
   return opentelemetry::sdk::configuration::YamlConfigurationFactory::ParseString(source, yaml);