Skip to content

Commit 3916a60

Browse files
committed
Code review comments, enum naming
1 parent a20b0b9 commit 3916a60

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

sdk/include/opentelemetry/sdk/configuration/otlp_http_encoding.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ namespace configuration
1515

1616
// YAML-SCHEMA: schema/common.json
1717
// YAML-NODE: OtlpHttpEncoding
18-
enum enum_otlp_http_encoding : std::uint8_t
18+
enum class OtlpHttpEncoding : std::uint8_t
1919
{
2020
protobuf,
2121
json

sdk/include/opentelemetry/sdk/configuration/otlp_http_log_record_exporter_configuration.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ class OtlpHttpLogRecordExporterConfiguration : public LogRecordExporterConfigura
3636
std::string headers_list;
3737
std::string compression;
3838
std::size_t timeout{0};
39-
enum_otlp_http_encoding encoding{protobuf};
39+
OtlpHttpEncoding encoding{OtlpHttpEncoding::protobuf};
4040
};
4141

4242
} // namespace configuration

sdk/include/opentelemetry/sdk/configuration/otlp_http_span_exporter_configuration.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ class OtlpHttpSpanExporterConfiguration : public SpanExporterConfiguration
3636
std::string headers_list;
3737
std::string compression;
3838
std::size_t timeout{0};
39-
enum_otlp_http_encoding encoding{protobuf};
39+
OtlpHttpEncoding encoding{OtlpHttpEncoding::protobuf};
4040
};
4141

4242
} // namespace configuration

0 commit comments

Comments
 (0)