Skip to content

Commit 3b31867

Browse files
committed
adjust after merge
1 parent 6c40847 commit 3b31867

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

sdk/src/configuration/sdk_builder.cc

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1490,12 +1490,8 @@ void SdkBuilder::AddView(
14901490
sdk_attribute_processor = CreateAttributesProcessor(stream->attribute_keys);
14911491
}
14921492

1493-
// FIXME-SDK: https://github.com/open-telemetry/opentelemetry-cpp/issues/3547
1494-
// FIXME-SDK: unit is unused in class View, should be removed.
1495-
std::string unit("FIXME-SDK");
1496-
14971493
auto sdk_view = std::make_unique<opentelemetry::sdk::metrics::View>(
1498-
stream->name, stream->description, unit, sdk_aggregation_type, sdk_aggregation_config,
1494+
stream->name, stream->description, sdk_aggregation_type, sdk_aggregation_config,
14991495
std::move(sdk_attribute_processor));
15001496

15011497
view_registry->AddView(std::move(sdk_instrument_selector), std::move(sdk_meter_selector),

0 commit comments

Comments
 (0)