Skip to content

Commit 3cd0385

Browse files
committed
grpc cleanup
1 parent 5173c79 commit 3cd0385

File tree

11 files changed

+26
-11
lines changed

11 files changed

+26
-11
lines changed

examples/grpc/client.cc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
// ambiguity with `nostd::variant` if compiled with Visual Studio 2015. Other
66
// modern compilers are unaffected.
77
#include <grpcpp/grpcpp.h>
8+
#include <grpcpp/security/credentials.h>
9+
#include <grpcpp/support/status.h>
810

911
#include <stdint.h>
1012
#include <stdlib.h>

examples/grpc/server.cc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// Copyright The OpenTelemetry Authors
22
// SPDX-License-Identifier: Apache-2.0
33

4-
#include <grpcpp/grpcpp.h>
54
#include <grpcpp/security/server_credentials.h>
65
#include <grpcpp/server.h>
76
#include <grpcpp/server_builder.h>
@@ -23,7 +22,7 @@
2322
#include "opentelemetry/semconv/incubating/rpc_attributes.h"
2423
#include "opentelemetry/trace/context.h"
2524
#include "opentelemetry/trace/span.h"
26-
#include "opentelemetry/trace/span_context_kv_iterable_view.h"
25+
#include "opentelemetry/trace/span_context.h"
2726
#include "opentelemetry/trace/span_metadata.h"
2827
#include "opentelemetry/trace/span_startoptions.h"
2928
#include "opentelemetry/trace/tracer.h"

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_client_factory.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,16 @@
55

66
#include <memory>
77

8+
#include "opentelemetry/exporters/otlp/otlp_grpc_client.h"
89
#include "opentelemetry/exporters/otlp/otlp_grpc_client_options.h"
9-
#include "opentelemetry/nostd/shared_ptr.h"
10+
#include "opentelemetry/version.h"
1011

1112
OPENTELEMETRY_BEGIN_NAMESPACE
1213
namespace exporter
1314
{
1415
namespace otlp
1516
{
1617

17-
class OtlpGrpcClientReferenceGuard;
18-
class OtlpGrpcClient;
19-
2018
/**
2119
* Factory class for OtlpGrpcClient.
2220
*/

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_utils.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
#pragma once
55

6-
#include <grpcpp/grpcpp.h>
6+
#include <grpcpp/support/status.h>
77

88
#include "opentelemetry/version.h"
99

exporters/otlp/test/otlp_grpc_exporter_factory_test.cc

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
#include <gtest/gtest.h>
55

6-
#include "opentelemetry/exporters/otlp/otlp_grpc_client_factory.h"
76
#include "opentelemetry/exporters/otlp/otlp_grpc_exporter_factory.h"
87
#include "opentelemetry/exporters/otlp/otlp_grpc_exporter_options.h"
98

@@ -15,6 +14,10 @@
1514
# error "protobuf should not be included"
1615
#endif
1716

17+
/*
18+
Implementation, this requires protobuf.
19+
*/
20+
#include "opentelemetry/exporters/otlp/otlp_grpc_client_factory.h"
1821
#include "opentelemetry/exporters/otlp/otlp_grpc_exporter.h"
1922

2023
OPENTELEMETRY_BEGIN_NAMESPACE

exporters/otlp/test/otlp_grpc_log_record_exporter_factory_test.cc

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
#include <gtest/gtest.h>
55

6-
#include "opentelemetry/exporters/otlp/otlp_grpc_client_factory.h"
76
#include "opentelemetry/exporters/otlp/otlp_grpc_log_record_exporter_factory.h"
87
#include "opentelemetry/exporters/otlp/otlp_grpc_log_record_exporter_options.h"
98

@@ -15,6 +14,10 @@
1514
# error "protobuf should not be included"
1615
#endif
1716

17+
/*
18+
Implementation, this requires protobuf.
19+
*/
20+
#include "opentelemetry/exporters/otlp/otlp_grpc_client_factory.h"
1821
#include "opentelemetry/exporters/otlp/otlp_grpc_log_record_exporter.h"
1922

2023
OPENTELEMETRY_BEGIN_NAMESPACE

exporters/otlp/test/otlp_grpc_metric_exporter_factory_test.cc

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
#include <gtest/gtest.h>
55

6-
#include "opentelemetry/exporters/otlp/otlp_grpc_client_factory.h"
76
#include "opentelemetry/exporters/otlp/otlp_grpc_metric_exporter_factory.h"
87
#include "opentelemetry/exporters/otlp/otlp_grpc_metric_exporter_options.h"
98

@@ -15,6 +14,10 @@
1514
# error "protobuf should not be included"
1615
#endif
1716

17+
/*
18+
Implementation, this requires protobuf.
19+
*/
20+
#include "opentelemetry/exporters/otlp/otlp_grpc_client_factory.h"
1821
#include "opentelemetry/exporters/otlp/otlp_grpc_metric_exporter.h"
1922

2023
OPENTELEMETRY_BEGIN_NAMESPACE

exporters/prometheus/include/opentelemetry/exporters/prometheus/collector.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
#include <mutex>
99
#include <vector>
1010

11-
#include "opentelemetry/exporters/prometheus/exporter_utils.h"
1211
#include "opentelemetry/sdk/metrics/metric_reader.h"
1312
#include "opentelemetry/version.h"
1413

exporters/prometheus/src/collector.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
// SPDX-License-Identifier: Apache-2.0
33

44
#include "opentelemetry/exporters/prometheus/collector.h"
5+
#include "opentelemetry/exporters/prometheus/exporter_utils.h"
56
#include "opentelemetry/sdk/common/global_log_handler.h"
67

78
namespace metric_sdk = opentelemetry::sdk::metrics;

exporters/prometheus/src/exporter.cc

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
// Copyright The OpenTelemetry Authors
22
// SPDX-License-Identifier: Apache-2.0
33

4+
#include <prometheus/exposer.h>
5+
#include <exception>
6+
#include <ostream>
7+
#include <string>
8+
49
#include "opentelemetry/exporters/prometheus/exporter.h"
510
#include "opentelemetry/sdk/common/global_log_handler.h"
611

0 commit comments

Comments
 (0)