Skip to content

Commit 59b6678

Browse files
committed
Merge cleanup
1 parent 8b490df commit 59b6678

File tree

2 files changed

+32
-11
lines changed

2 files changed

+32
-11
lines changed
Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
// Copyright The OpenTelemetry Authors
2+
// SPDX-License-Identifier: Apache-2.0
3+
4+
#pragma once
5+
6+
#include <cstdint>
7+
8+
#include "opentelemetry/version.h"
9+
10+
OPENTELEMETRY_BEGIN_NAMESPACE
11+
namespace sdk
12+
{
13+
namespace configuration
14+
{
15+
16+
// YAML-SCHEMA: schema/meter_provider.json
17+
// YAML-NODE: InstrumentType
18+
enum class InstrumentType : std::uint8_t
19+
{
20+
counter,
21+
histogram,
22+
observable_counter,
23+
observable_gauge,
24+
observable_up_down_counter,
25+
up_down_counter
26+
};
27+
28+
} // namespace configuration
29+
} // namespace sdk
30+
OPENTELEMETRY_END_NAMESPACE

sdk/include/opentelemetry/sdk/configuration/view_selector_configuration.h

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
#include <memory>
88
#include <string>
99

10+
#include "opentelemetry/sdk/configuration/instrument_type.h"
1011
#include "opentelemetry/version.h"
1112

1213
OPENTELEMETRY_BEGIN_NAMESPACE
@@ -15,16 +16,6 @@ namespace sdk
1516
namespace configuration
1617
{
1718

18-
enum enum_instrument_type : std::uint8_t
19-
{
20-
counter,
21-
histogram,
22-
observable_counter,
23-
observable_gauge,
24-
observable_up_down_counter,
25-
up_down_counter
26-
};
27-
2819
// YAML-SCHEMA: schema/meter_provider.json
2920
// YAML-NODE: ViewSelector
3021
class ViewSelectorConfiguration
@@ -38,7 +29,7 @@ class ViewSelectorConfiguration
3829
~ViewSelectorConfiguration() = default;
3930

4031
std::string instrument_name;
41-
enum_instrument_type instrument_type{counter};
32+
InstrumentType instrument_type{InstrumentType::counter};
4233
std::string unit;
4334
std::string meter_name;
4435
std::string meter_version;

0 commit comments

Comments
 (0)