Skip to content

Commit 6155bd6

Browse files
committed
fix clang-tidy cppcoreguidelines-special-member-functions warnings
1 parent 3b42db5 commit 6155bd6

11 files changed

+23
-10
lines changed

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_client.h

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,11 @@ class OtlpGrpcClient
106106
{
107107
public:
108108
OtlpGrpcClient(const OtlpGrpcClientOptions &options);
109-
110109
~OtlpGrpcClient();
110+
OtlpGrpcClient(const OtlpGrpcClient &) = delete;
111+
OtlpGrpcClient(OtlpGrpcClient &&) = delete;
112+
OtlpGrpcClient &operator=(const OtlpGrpcClient &) = delete;
113+
OtlpGrpcClient &operator=(OtlpGrpcClient &&) = delete;
111114

112115
static std::string GetGrpcTarget(const std::string &endpoint);
113116

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_client_options.h

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,13 @@ namespace otlp
2323

2424
struct OtlpGrpcClientOptions
2525
{
26+
virtual ~OtlpGrpcClientOptions() = default;
27+
OtlpGrpcClientOptions() = default;
28+
OtlpGrpcClientOptions(const OtlpGrpcClientOptions &) = default;
29+
OtlpGrpcClientOptions(OtlpGrpcClientOptions &&) = default;
30+
OtlpGrpcClientOptions &operator=(const OtlpGrpcClientOptions &) = default;
31+
OtlpGrpcClientOptions &operator=(OtlpGrpcClientOptions &&) = default;
32+
2633
/** The endpoint to export to. */
2734
std::string endpoint;
2835

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_exporter.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,10 @@ class OtlpGrpcExporter final : public opentelemetry::sdk::trace::SpanExporter
5858
explicit OtlpGrpcExporter(const OtlpGrpcExporterOptions &options);
5959

6060
~OtlpGrpcExporter() override;
61+
OtlpGrpcExporter(const OtlpGrpcExporter &) = delete;
62+
OtlpGrpcExporter(OtlpGrpcExporter &&) = delete;
63+
OtlpGrpcExporter &operator=(const OtlpGrpcExporter &) = delete;
64+
OtlpGrpcExporter &operator=(OtlpGrpcExporter &&) = delete;
6165

6266
/**
6367
* Create a span recordable.

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_exporter_options.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ namespace otlp
2424
struct OPENTELEMETRY_EXPORT OtlpGrpcExporterOptions : public OtlpGrpcClientOptions
2525
{
2626
OtlpGrpcExporterOptions();
27-
~OtlpGrpcExporterOptions();
2827
};
2928

3029
} // namespace otlp

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_log_record_exporter.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,10 @@ class OtlpGrpcLogRecordExporter : public opentelemetry::sdk::logs::LogRecordExpo
5757
OtlpGrpcLogRecordExporter(const OtlpGrpcLogRecordExporterOptions &options);
5858

5959
~OtlpGrpcLogRecordExporter() override;
60+
OtlpGrpcLogRecordExporter(const OtlpGrpcLogRecordExporter &) = delete;
61+
OtlpGrpcLogRecordExporter(OtlpGrpcLogRecordExporter &&) = delete;
62+
OtlpGrpcLogRecordExporter &operator=(const OtlpGrpcLogRecordExporter &) = delete;
63+
OtlpGrpcLogRecordExporter &operator=(OtlpGrpcLogRecordExporter &&) = delete;
6064

6165
/**
6266
* Creates a recordable that stores the data in protobuf.

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_log_record_exporter_options.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ namespace otlp
2424
struct OPENTELEMETRY_EXPORT OtlpGrpcLogRecordExporterOptions : public OtlpGrpcClientOptions
2525
{
2626
OtlpGrpcLogRecordExporterOptions();
27-
~OtlpGrpcLogRecordExporterOptions();
2827
};
2928

3029
} // namespace otlp

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_metric_exporter.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,10 @@ class OtlpGrpcMetricExporter : public opentelemetry::sdk::metrics::PushMetricExp
5555
explicit OtlpGrpcMetricExporter(const OtlpGrpcMetricExporterOptions &options);
5656

5757
~OtlpGrpcMetricExporter() override;
58+
OtlpGrpcMetricExporter(const OtlpGrpcMetricExporter &) = delete;
59+
OtlpGrpcMetricExporter(OtlpGrpcMetricExporter &&) = delete;
60+
OtlpGrpcMetricExporter &operator=(const OtlpGrpcMetricExporter &) = delete;
61+
OtlpGrpcMetricExporter &operator=(OtlpGrpcMetricExporter &&) = delete;
5862

5963
/**
6064
* Get the AggregationTemporality for exporter

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_metric_exporter_options.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ namespace otlp
2525
struct OPENTELEMETRY_EXPORT OtlpGrpcMetricExporterOptions : public OtlpGrpcClientOptions
2626
{
2727
OtlpGrpcMetricExporterOptions();
28-
~OtlpGrpcMetricExporterOptions();
2928

3029
/** Preferred Aggregation Temporality. */
3130
PreferredAggregationTemporality aggregation_temporality;

exporters/otlp/src/otlp_grpc_exporter_options.cc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,6 @@ OtlpGrpcExporterOptions::OtlpGrpcExporterOptions()
4545
retry_policy_backoff_multiplier = GetOtlpDefaultTracesRetryBackoffMultiplier();
4646
}
4747

48-
OtlpGrpcExporterOptions::~OtlpGrpcExporterOptions() {}
49-
5048
} // namespace otlp
5149
} // namespace exporter
5250
OPENTELEMETRY_END_NAMESPACE

exporters/otlp/src/otlp_grpc_log_record_exporter_options.cc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,6 @@ OtlpGrpcLogRecordExporterOptions::OtlpGrpcLogRecordExporterOptions()
4545
retry_policy_backoff_multiplier = GetOtlpDefaultLogsRetryBackoffMultiplier();
4646
}
4747

48-
OtlpGrpcLogRecordExporterOptions::~OtlpGrpcLogRecordExporterOptions() {}
49-
5048
} // namespace otlp
5149
} // namespace exporter
5250
OPENTELEMETRY_END_NAMESPACE

0 commit comments

Comments
 (0)