review comments

esigo · web-flow · commit 6512381df4f6 · 2025-01-12T18:30:45.000+01:00
diff --git a/ci/README.md b/ci/README.md
@@ -1,6 +1,7 @@
 # Building and running tests as a developer
 
-CI tests can be run inside
+CI tests can be run on docker by invoking the script `./ci/run_docker.sh
+./ci/do_ci.sh {TARGET}`or inside
 [devcontainer](../CONTRIBUTING.md#devcontainer-setup-for-project)
 by invoking the script
 `./ci/do_ci.sh {TARGET}` where the targets are:
diff --git a/ci/run_docker.sh b/ci/run_docker.sh
@@ -7,7 +7,7 @@ set -e
 
 BUILD_IMAGE=opentelemetry-cpp-build
 docker image inspect "$BUILD_IMAGE" &> /dev/null || {
-  docker build -t "$BUILD_IMAGE" ci
+  docker build -t "$BUILD_IMAGE" -f .devcontainer/Dockerfile.dev .
 }
 
 if [[ $# -ge 1 ]]; then

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ set -e`
`7`	`7`
`8`	`8`	`BUILD_IMAGE=opentelemetry-cpp-build`
`9`	`9`	`docker image inspect "$BUILD_IMAGE" &> /dev/null \|\| {`
`10`		`- docker build -t "$BUILD_IMAGE" ci`
	`10`	`+ docker build -t "$BUILD_IMAGE" -f .devcontainer/Dockerfile.dev .`
`11`	`11`	`}`
`12`	`12`
`13`	`13`	`if [[ $# -ge 1 ]]; then`