fix clang-tidy cppcoreguidelines-rvalue-reference-param-not-moved warnings

Author: dbarker

api/test/logs/logger_test.cc

@@ -206,7 +206,10 @@ class TestLogger : public Logger
 
   using Logger::EmitLogRecord;
 
-  void EmitLogRecord(nostd::unique_ptr<opentelemetry::logs::LogRecord> &&) noexcept override {}
+  // NOLINTNEXTLINE(cppcoreguidelines-rvalue-reference-param-not-moved)
+  void EmitLogRecord(
+      nostd::unique_ptr<opentelemetry::logs::LogRecord> && /*log_record*/) noexcept override
+  {}
 };
 
 // Define a basic LoggerProvider class that returns an instance of the logger class defined above

exporters/otlp/src/otlp_grpc_client.cc

@@ -173,10 +173,12 @@ static sdk::common::ExportResult InternalDelegateAsyncExport(
     OTEL_INTERNAL_LOG_ERROR("[OTLP GRPC Client] ERROR: Export "
                             << export_data_count << " " << export_data_name
                             << " failed, exporter queue is full");
-    if (result_callback)
+
+    auto result_callback_fn = std::move(result_callback);
+    if (result_callback_fn)
     {
-      result_callback(opentelemetry::sdk::common::ExportResult::kFailureFull, std::move(arena),
-                      request, nullptr);
+      result_callback_fn(opentelemetry::sdk::common::ExportResult::kFailureFull, std::move(arena),
+                         request, nullptr);
     }
     return opentelemetry::sdk::common::ExportResult::kFailureFull;
   }
@@ -205,7 +207,8 @@ static sdk::common::ExportResult InternalDelegateAsyncExport(
 
     return opentelemetry::sdk::common::ExportResult::kFailure;
   }
-  call_data->grpc_context.swap(context);
+  auto context_ptr = std::move(context);
+  call_data->grpc_context.swap(context_ptr);
 
   call_data->grpc_async_callback = [](OtlpGrpcAsyncCallDataBase *base_call_data) {
     OtlpGrpcAsyncCallData<RequestType, ResponseType> *real_call_data =
@@ -519,31 +522,40 @@ OtlpGrpcClient::MakeLogsServiceStub()
 grpc::Status OtlpGrpcClient::DelegateExport(
     proto::collector::trace::v1::TraceService::StubInterface *stub,
     std::unique_ptr<grpc::ClientContext> &&context,
-    std::unique_ptr<google::protobuf::Arena> && /*arena*/,
+    std::unique_ptr<google::protobuf::Arena> &&arena,
     proto::collector::trace::v1::ExportTraceServiceRequest &&request,
     proto::collector::trace::v1::ExportTraceServiceResponse *response)
 {
-  return stub->Export(context.get(), request, response);
+  auto context_ptr = std::move(context);
+  auto arena_ptr   = std::move(arena);
+  auto request_ptr = std::move(request);
+  return stub->Export(context_ptr.get(), request_ptr, response);
 }
 
 grpc::Status OtlpGrpcClient::DelegateExport(
     proto::collector::metrics::v1::MetricsService::StubInterface *stub,
     std::unique_ptr<grpc::ClientContext> &&context,
-    std::unique_ptr<google::protobuf::Arena> && /*arena*/,
+    std::unique_ptr<google::protobuf::Arena> &&arena,
     proto::collector::metrics::v1::ExportMetricsServiceRequest &&request,
     proto::collector::metrics::v1::ExportMetricsServiceResponse *response)
 {
-  return stub->Export(context.get(), request, response);
+  auto context_ptr = std::move(context);
+  auto arena_ptr   = std::move(arena);
+  auto request_ptr = std::move(request);
+  return stub->Export(context_ptr.get(), request_ptr, response);
 }
 
 grpc::Status OtlpGrpcClient::DelegateExport(
     proto::collector::logs::v1::LogsService::StubInterface *stub,
     std::unique_ptr<grpc::ClientContext> &&context,
-    std::unique_ptr<google::protobuf::Arena> && /*arena*/,
+    std::unique_ptr<google::protobuf::Arena> &&arena,
     proto::collector::logs::v1::ExportLogsServiceRequest &&request,
     proto::collector::logs::v1::ExportLogsServiceResponse *response)
 {
-  return stub->Export(context.get(), request, response);
+  auto context_ptr = std::move(context);
+  auto arena_ptr   = std::move(arena);
+  auto request_ptr = std::move(request);
+  return stub->Export(context_ptr.get(), request_ptr, response);
 }
 
 void OtlpGrpcClient::AddReference(OtlpGrpcClientReferenceGuard &guard,

exporters/otlp/src/otlp_grpc_exporter.cc

@@ -151,9 +151,10 @@ sdk::common::ExportResult OtlpGrpcExporter::Export(
         // called.
         [trace_service_stub = trace_service_stub_](
             opentelemetry::sdk::common::ExportResult result,
-            std::unique_ptr<google::protobuf::Arena> &&,
+            std::unique_ptr<google::protobuf::Arena> &&arena,
             const proto::collector::trace::v1::ExportTraceServiceRequest &request,
             proto::collector::trace::v1::ExportTraceServiceResponse *) {
+          auto arena_ptr = std::move(arena);
           if (result != opentelemetry::sdk::common::ExportResult::kSuccess)
           {
             OTEL_INTERNAL_LOG_ERROR("[OTLP TRACE GRPC Exporter] ERROR: Export "

exporters/otlp/src/otlp_grpc_log_record_exporter.cc

@@ -155,9 +155,10 @@ opentelemetry::sdk::common::ExportResult OtlpGrpcLogRecordExporter::Export(
         // called.
         [log_service_stub = log_service_stub_](
             opentelemetry::sdk::common::ExportResult result,
-            std::unique_ptr<google::protobuf::Arena> &&,
+            std::unique_ptr<google::protobuf::Arena> &&arena,
             const proto::collector::logs::v1::ExportLogsServiceRequest &request,
             proto::collector::logs::v1::ExportLogsServiceResponse *) {
+          auto arena_ptr = std::move(arena);
           if (result != opentelemetry::sdk::common::ExportResult::kSuccess)
           {
             OTEL_INTERNAL_LOG_ERROR("[OTLP LOG GRPC Exporter] ERROR: Export "

exporters/otlp/src/otlp_grpc_metric_exporter.cc

@@ -165,9 +165,10 @@ opentelemetry::sdk::common::ExportResult OtlpGrpcMetricExporter::Export(
         // called.
         [metrics_service_stub = metrics_service_stub_](
             opentelemetry::sdk::common::ExportResult result,
-            std::unique_ptr<google::protobuf::Arena> &&,
+            std::unique_ptr<google::protobuf::Arena> &&arena,
             const proto::collector::metrics::v1::ExportMetricsServiceRequest &request,
             proto::collector::metrics::v1::ExportMetricsServiceResponse *) {
+          auto arena_ptr = std::move(arena);
           if (result != opentelemetry::sdk::common::ExportResult::kSuccess)
           {
             OTEL_INTERNAL_LOG_ERROR("[OTLP METRIC GRPC Exporter] ERROR: Export "

sdk/test/common/circular_buffer_benchmark.cc

@@ -29,8 +29,10 @@ static uint64_t ConsumeBufferNumbers(BaselineCircularBuffer<uint64_t> &buffer) n
 {
   uint64_t result = 0;
   buffer.Consume([&](std::unique_ptr<uint64_t> &&x) {
-    result += *x;
-    x.reset();
+    auto val = std::move(x);
+
+    result += *val;
+    val.reset();
   });
   return result;
 }

sdk/test/logs/logger_provider_sdk_test.cc

@@ -224,6 +224,7 @@ class DummyProcessor : public LogRecordProcessor
     return std::unique_ptr<Recordable>(new DummyLogRecordable());
   }
 
+  // NOLINTNEXTLINE(cppcoreguidelines-rvalue-reference-param-not-moved)
   void OnEmit(std::unique_ptr<Recordable> && /* record */) noexcept override {}
   bool ForceFlush(std::chrono::microseconds /* timeout */) noexcept override { return true; }
   bool Shutdown(std::chrono::microseconds /* timeout */) noexcept override { return true; }