Fix handling of without_type_suffix with gauges

psx95 · psx95 · commit 66c9c73fa104 · 2024-10-16T21:00:04.000Z
diff --git a/exporters/prometheus/src/exporter_utils.cc b/exporters/prometheus/src/exporter_utils.cc
@@ -530,8 +530,9 @@ std::string PrometheusExporterUtils::MapToPrometheusName(
 
   // Special case - gauge
   if (unit == "1" && prometheus_type == prometheus_client::MetricType::Gauge &&
-      sanitized_name.find("ratio") == std::string::npos && !without_type_suffix)
+      sanitized_name.find("ratio") == std::string::npos && !without_units)
   {
+    // this is replacing the unit name
     sanitized_name += "_ratio";
   }
 

Original file line number	Diff line number	Diff line change
`@@ -530,8 +530,9 @@ std::string PrometheusExporterUtils::MapToPrometheusName(`
`530`	`530`
`531`	`531`	`// Special case - gauge`
`532`	`532`	`if (unit == "1" && prometheus_type == prometheus_client::MetricType::Gauge &&`
`533`		`- sanitized_name.find("ratio") == std::string::npos && !without_type_suffix)`
	`533`	`+ sanitized_name.find("ratio") == std::string::npos && !without_units)`
`534`	`534`	`{`
	`535`	`+ // this is replacing the unit name`
`535`	`536`	`sanitized_name += "_ratio";`
`536`	`537`	`}`
`537`	`538`