Skip to content

Commit 7db9749

Browse files
committed
address review feedback. Changelog entry. Remove setting policies that are the default with 3.16
1 parent 2dbe049 commit 7db9749

File tree

2 files changed

+5
-16
lines changed

2 files changed

+5
-16
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,11 @@ Increment the:
3030
* [SDK] View should not have a unit
3131
[#3552](https://github.com/open-telemetry/opentelemetry-cpp/pull/3552)
3232

33+
Important changes:
34+
35+
* [CMAKE] Upgrade CMake minimum version to 3.16
36+
[#3599](https://github.com/open-telemetry/opentelemetry-cpp/pull/3599)
37+
3338
Breaking changes:
3439

3540
* [SDK] View should not have a unit

CMakeLists.txt

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -3,22 +3,6 @@
33

44
cmake_minimum_required(VERSION 3.16)
55

6-
# See https://cmake.org/cmake/help/latest/policy/CMP0074.html required by
7-
# certain version of zlib which CURL depends on.
8-
if(${CMAKE_VERSION} VERSION_GREATER_EQUAL "3.12")
9-
cmake_policy(SET CMP0074 NEW)
10-
endif()
11-
12-
# Allow to use normal variable for option()
13-
if(${CMAKE_VERSION} VERSION_GREATER_EQUAL "3.13")
14-
cmake_policy(SET CMP0077 NEW)
15-
endif()
16-
17-
# Prefer CMAKE_MSVC_RUNTIME_LIBRARY if possible
18-
if(POLICY CMP0091)
19-
cmake_policy(SET CMP0091 NEW)
20-
endif()
21-
226
if(POLICY CMP0092)
237
# https://cmake.org/cmake/help/latest/policy/CMP0092.html#policy:CMP0092 Make
248
# sure the /W3 is not removed from CMAKE_CXX_FLAGS since CMake 3.15

0 commit comments

Comments
 (0)