set the clang-tidy warning limits. fix iwyu error count step

Author: dbarker

.github/workflows/clang-tidy.yaml

@@ -11,15 +11,15 @@ permissions:
 
 jobs:
   clang-tidy:
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
         include:
           - cmake_options: all-options-abiv1-preview
-            warning_limit: 236
+            warning_limit: 215
           - cmake_options: all-options-abiv2-preview
-            warning_limit: 236
+            warning_limit: 216
     steps:
       - name: Harden the runner (Audit all outbound calls)
         uses: step-security/harden-runner@0634a2670c59f64b4a01f0f96f84700a4088b9f0 # v2.12.0

.github/workflows/iwyu.yml

@@ -66,6 +66,7 @@ jobs:
             -C ./test_common/cmake/${{ matrix.cmake_options }}.cmake \
             -DCMAKE_CXX_STANDARD=14 \
             -DWITH_STL=CXX14 \
+            -DCMAKE_CXX_FLAGS="-Wno-deprecated-declarations" \
             -DCMAKE_CXX_INCLUDE_WHAT_YOU_USE="include-what-you-use;-w;-Xiwyu;--mapping_file=${TOPDIR}/.iwyu.imp;"
 
       - name: iwyu_tool
@@ -83,7 +84,6 @@ jobs:
           set +e
           echo "include-what-you-use version:"
           include-what-you-use --version
-          cd build-${{ matrix.cmake_options }}
           readonly WARNING_COUNT=`grep -c "include-what-you-use reported diagnostics:" iwyu-${{ matrix.cmake_options }}.log`
           echo "include-what-you-use reported ${WARNING_COUNT} warning(s) with cmake options preset '${{ matrix.cmake_options }}'"
           # Acceptable limit, to decrease over time down to 0