Fix initialization order of isClosed_ in EtwTracer

Author: beep-boopp

exporters/etw/include/opentelemetry/exporters/etw/etw_tracer.h

@@ -162,7 +162,10 @@ void UpdateStatus(T &t, Properties &props)
 
 class Tracer : public opentelemetry::trace::Tracer,
                public std::enable_shared_from_this<opentelemetry::trace::Tracer>
+              
 {
+  // To let test verify private state
+  friend class ETWTracer_ConstructorInitializesToOpenState_Test;
 
   /**
    * @brief Parent provider of this Tracer
@@ -182,11 +185,19 @@ class Tracer : public opentelemetry::trace::Tracer,
   /**
    * @brief Provider Handle
    */
-  ETWProvider::Handle &provHandle;
+  //change made in pr 
+  // ETWProvider::Handle &provHandle;
 
-  opentelemetry::trace::TraceId traceId_;
+  // opentelemetry::trace::TraceId traceId_;
+
+  // std::atomic<bool> isClosed_{true};
 
-  std::atomic<bool> isClosed_{true};
+  // Fix: Declare isClosed_ before provHandle so it initializes to true 
+  // *before* initProvHandle() runs.
+  std::atomic<bool> isClosed_{true}; 
+
+  ETWProvider::Handle &provHandle;
+  opentelemetry::trace::TraceId traceId_;
 
   /**
    * @brief ETWProvider is a singleton that aggregates all ETW writes.

exporters/etw/test/etw_tracer_test.cc

@@ -566,6 +566,22 @@ TEST(ETWTracer, EndWithCustomTime)
 
 }
 
+TEST(ETWTracer, ConstructorInitializesToOpenState)
+{
+  // Setup - Create a mock/real provider dependency
+  etw::TracerProvider provider;
+  std::string providerId = "TestProvider";
+
+  // Instantiate the Tracer
+  // This triggers the constructor -> initProvHandle sequence
+  opentelemetry::exporter::etw::Tracer tracer(provider, providerId);
+
+  //  Verify the Bug Fix
+  // Because we added the 'friend' line in the header, we can access isClosed_ directly.
+  // It should be FALSE (Open) now. Before your fix, this was TRUE.
+  EXPECT_FALSE(tracer.isClosed_);
+}
+
 /* clang-format on */
 
 #endif