Skip to content

Commit 85ea91f

Browse files
authored
Jaeger exporter shutdown (#1150)
1 parent f60eec2 commit 85ea91f

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

exporters/jaeger/include/opentelemetry/exporters/jaeger/jaeger_exporter.h

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,7 @@ class JaegerExporter final : public opentelemetry::sdk::trace::SpanExporter
6565
* @param timeout an option timeout, default to max.
6666
*/
6767
bool Shutdown(
68-
std::chrono::microseconds timeout = std::chrono::microseconds::max()) noexcept override
69-
{
70-
return true;
71-
}
68+
std::chrono::microseconds timeout = std::chrono::microseconds::max()) noexcept override;
7269

7370
private:
7471
void InitializeEndpoint();

exporters/jaeger/src/jaeger_exporter.cc

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,12 @@ void JaegerExporter::InitializeEndpoint()
8585
assert(false);
8686
}
8787

88+
bool JaegerExporter::Shutdown(std::chrono::microseconds timeout) noexcept
89+
{
90+
is_shutdown_ = true;
91+
return true;
92+
}
93+
8894
} // namespace jaeger
8995
} // namespace exporter
9096
OPENTELEMETRY_END_NAMESPACE

0 commit comments

Comments
 (0)