Skip to content

Commit 8cd1b6b

Browse files
committed
Code review comments, rule of 0, misc cleanup
1 parent 22b5ecb commit 8cd1b6b

File tree

16 files changed

+1
-58
lines changed

16 files changed

+1
-58
lines changed

exporters/ostream/include/opentelemetry/exporters/ostream/console_log_record_builder.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@ class OPENTELEMETRY_EXPORT ConsoleLogRecordBuilder
2323
public:
2424
static void Register(opentelemetry::sdk::configuration::Registry *registry);
2525

26-
ConsoleLogRecordBuilder() = default;
27-
~ConsoleLogRecordBuilder() override = default;
28-
2926
std::unique_ptr<opentelemetry::sdk::logs::LogRecordExporter> Build(
3027
const opentelemetry::sdk::configuration::ConsoleLogRecordExporterConfiguration *model)
3128
const override;

exporters/ostream/include/opentelemetry/exporters/ostream/console_push_metric_builder.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@ class OPENTELEMETRY_EXPORT ConsolePushMetricBuilder
2323
public:
2424
static void Register(opentelemetry::sdk::configuration::Registry *registry);
2525

26-
ConsolePushMetricBuilder() = default;
27-
~ConsolePushMetricBuilder() override = default;
28-
2926
std::unique_ptr<opentelemetry::sdk::metrics::PushMetricExporter> Build(
3027
const opentelemetry::sdk::configuration::ConsolePushMetricExporterConfiguration *model)
3128
const override;

exporters/ostream/include/opentelemetry/exporters/ostream/console_span_builder.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@ class OPENTELEMETRY_EXPORT ConsoleSpanBuilder
2323
public:
2424
static void Register(opentelemetry::sdk::configuration::Registry *registry);
2525

26-
ConsoleSpanBuilder() = default;
27-
~ConsoleSpanBuilder() override = default;
28-
2926
std::unique_ptr<opentelemetry::sdk::trace::SpanExporter> Build(
3027
const opentelemetry::sdk::configuration::ConsoleSpanExporterConfiguration *model)
3128
const override;

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_file_log_record_builder.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@ class OPENTELEMETRY_EXPORT OtlpFileLogRecordBuilder
2323
public:
2424
static void Register(opentelemetry::sdk::configuration::Registry *registry);
2525

26-
OtlpFileLogRecordBuilder() = default;
27-
~OtlpFileLogRecordBuilder() override = default;
28-
2926
std::unique_ptr<opentelemetry::sdk::logs::LogRecordExporter> Build(
3027
const opentelemetry::sdk::configuration::OtlpFileLogRecordExporterConfiguration *model)
3128
const override;

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_file_push_metric_builder.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@ class OPENTELEMETRY_EXPORT OtlpFilePushMetricBuilder
2323
public:
2424
static void Register(opentelemetry::sdk::configuration::Registry *registry);
2525

26-
OtlpFilePushMetricBuilder() = default;
27-
~OtlpFilePushMetricBuilder() override = default;
28-
2926
std::unique_ptr<opentelemetry::sdk::metrics::PushMetricExporter> Build(
3027
const opentelemetry::sdk::configuration::OtlpFilePushMetricExporterConfiguration *model)
3128
const override;

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_file_span_builder.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@ class OPENTELEMETRY_EXPORT OtlpFileSpanBuilder
2323
public:
2424
static void Register(opentelemetry::sdk::configuration::Registry *registry);
2525

26-
OtlpFileSpanBuilder() = default;
27-
~OtlpFileSpanBuilder() override = default;
28-
2926
std::unique_ptr<opentelemetry::sdk::trace::SpanExporter> Build(
3027
const opentelemetry::sdk::configuration::OtlpFileSpanExporterConfiguration *model)
3128
const override;

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_log_record_builder.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@ class OPENTELEMETRY_EXPORT OtlpGrpcLogRecordBuilder
2323
public:
2424
static void Register(opentelemetry::sdk::configuration::Registry *registry);
2525

26-
OtlpGrpcLogRecordBuilder() = default;
27-
~OtlpGrpcLogRecordBuilder() override = default;
28-
2926
std::unique_ptr<opentelemetry::sdk::logs::LogRecordExporter> Build(
3027
const opentelemetry::sdk::configuration::OtlpGrpcLogRecordExporterConfiguration *model)
3128
const override;

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_push_metric_builder.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@ class OPENTELEMETRY_EXPORT OtlpGrpcPushMetricBuilder
2323
public:
2424
static void Register(opentelemetry::sdk::configuration::Registry *registry);
2525

26-
OtlpGrpcPushMetricBuilder() = default;
27-
~OtlpGrpcPushMetricBuilder() override = default;
28-
2926
std::unique_ptr<opentelemetry::sdk::metrics::PushMetricExporter> Build(
3027
const opentelemetry::sdk::configuration::OtlpGrpcPushMetricExporterConfiguration *model)
3128
const override;

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_span_builder.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@ class OPENTELEMETRY_EXPORT OtlpGrpcSpanBuilder
2323
public:
2424
static void Register(opentelemetry::sdk::configuration::Registry *registry);
2525

26-
OtlpGrpcSpanBuilder() = default;
27-
~OtlpGrpcSpanBuilder() override = default;
28-
2926
std::unique_ptr<opentelemetry::sdk::trace::SpanExporter> Build(
3027
const opentelemetry::sdk::configuration::OtlpGrpcSpanExporterConfiguration *model)
3128
const override;

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_log_record_builder.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@ class OPENTELEMETRY_EXPORT OtlpHttpLogRecordBuilder
2323
public:
2424
static void Register(opentelemetry::sdk::configuration::Registry *registry);
2525

26-
OtlpHttpLogRecordBuilder() = default;
27-
~OtlpHttpLogRecordBuilder() override = default;
28-
2926
std::unique_ptr<opentelemetry::sdk::logs::LogRecordExporter> Build(
3027
const opentelemetry::sdk::configuration::OtlpHttpLogRecordExporterConfiguration *model)
3128
const override;

0 commit comments

Comments
 (0)