Skip to content

Commit 9dd19a2

Browse files
authored
Change BatchLogRecordProcessorFactory::Create to static method, Fixed a typo in a comment (#1876)
1 parent 066c2f3 commit 9dd19a2

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ Increment the:
1515

1616
## [Unreleased]
1717

18+
* [METRICS] Change BatchLogRecordProcessorFactory::Create to static method
1819
* [BUILD] Fix OTELCPP_MAINTAINER_MODE [#1844](https://github.com/open-telemetry/opentelemetry-cpp/pull/1844)
1920
* [BUILD] Fix compatibility when using clang and libc++, upgrade GTest and
2021
cmake when using C++20 [#1852](https://github.com/open-telemetry/opentelemetry-cpp/pull/1852)

sdk/include/opentelemetry/sdk/common/global_log_handler.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ class GlobalLogHandler
134134
OPENTELEMETRY_END_NAMESPACE
135135

136136
/**
137-
* GlobalLogHandler and TracerProvider/MeterProvider/LoggerProvider are lazy sigletons.
137+
* GlobalLogHandler and TracerProvider/MeterProvider/LoggerProvider are lazy singletons.
138138
* To ensure that GlobalLogHandler is the first one to be initialized (and so last to be
139139
* destroyed), it is first used inside the constructors of TraceProvider, MeterProvider
140140
* and LoggerProvider for debug logging. */

sdk/include/opentelemetry/sdk/logs/batch_log_record_processor_factory.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ class BatchLogRecordProcessorFactory
2727
/**
2828
* Create a BatchLogRecordProcessor.
2929
*/
30-
std::unique_ptr<LogRecordProcessor> Create(std::unique_ptr<LogRecordExporter> &&exporter,
31-
const BatchLogRecordProcessorOptions &options);
30+
static std::unique_ptr<LogRecordProcessor> Create(std::unique_ptr<LogRecordExporter> &&exporter,
31+
const BatchLogRecordProcessorOptions &options);
3232
};
3333

3434
} // namespace logs

0 commit comments

Comments
 (0)