Refresh code from PR #2518, to fix review comments (clang-tidy)

Author: marcalff

sdk/include/opentelemetry/sdk/configuration/always_off_sampler_configuration.h

@@ -18,9 +18,6 @@ namespace configuration
 class AlwaysOffSamplerConfiguration : public SamplerConfiguration
 {
 public:
-  AlwaysOffSamplerConfiguration()           = default;
-  ~AlwaysOffSamplerConfiguration() override = default;
-
   void Accept(SamplerConfigurationVisitor *visitor) const override
   {
     visitor->VisitAlwaysOff(this);

sdk/include/opentelemetry/sdk/configuration/always_on_sampler_configuration.h

@@ -18,9 +18,6 @@ namespace configuration
 class AlwaysOnSamplerConfiguration : public SamplerConfiguration
 {
 public:
-  AlwaysOnSamplerConfiguration()           = default;
-  ~AlwaysOnSamplerConfiguration() override = default;
-
   void Accept(SamplerConfigurationVisitor *visitor) const override { visitor->VisitAlwaysOn(this); }
 };
 

sdk/include/opentelemetry/sdk/configuration/jaeger_remote_sampler_configuration.h

@@ -21,16 +21,13 @@ namespace configuration
 class JaegerRemoteSamplerConfiguration : public SamplerConfiguration
 {
 public:
-  JaegerRemoteSamplerConfiguration()           = default;
-  ~JaegerRemoteSamplerConfiguration() override = default;
-
   void Accept(SamplerConfigurationVisitor *visitor) const override
   {
     visitor->VisitJaegerRemote(this);
   }
 
   std::string endpoint;
-  size_t interval{0};
+  std::size_t interval{0};
   std::unique_ptr<SamplerConfiguration> initial_sampler;
 };
 

sdk/include/opentelemetry/sdk/configuration/parent_based_sampler_configuration.h

@@ -20,9 +20,6 @@ namespace configuration
 class ParentBasedSamplerConfiguration : public SamplerConfiguration
 {
 public:
-  ParentBasedSamplerConfiguration()           = default;
-  ~ParentBasedSamplerConfiguration() override = default;
-
   void Accept(SamplerConfigurationVisitor *visitor) const override
   {
     visitor->VisitParentBased(this);

sdk/include/opentelemetry/sdk/configuration/sampler_configuration.h

@@ -18,8 +18,12 @@ class SamplerConfigurationVisitor;
 class SamplerConfiguration
 {
 public:
-  SamplerConfiguration()          = default;
-  virtual ~SamplerConfiguration() = default;
+  SamplerConfiguration()                                             = default;
+  SamplerConfiguration(SamplerConfiguration &&)                      = default;
+  SamplerConfiguration(const SamplerConfiguration &)                 = default;
+  SamplerConfiguration &operator=(SamplerConfiguration &&)           = default;
+  SamplerConfiguration &operator=(const SamplerConfiguration &other) = default;
+  virtual ~SamplerConfiguration()                                    = default;
 
   virtual void Accept(SamplerConfigurationVisitor *visitor) const = 0;
 };

sdk/include/opentelemetry/sdk/configuration/sampler_configuration_visitor.h

@@ -21,8 +21,12 @@ class ExtensionSamplerConfiguration;
 class SamplerConfigurationVisitor
 {
 public:
-  SamplerConfigurationVisitor()          = default;
-  virtual ~SamplerConfigurationVisitor() = default;
+  SamplerConfigurationVisitor()                                                    = default;
+  SamplerConfigurationVisitor(SamplerConfigurationVisitor &&)                      = default;
+  SamplerConfigurationVisitor(const SamplerConfigurationVisitor &)                 = default;
+  SamplerConfigurationVisitor &operator=(SamplerConfigurationVisitor &&)           = default;
+  SamplerConfigurationVisitor &operator=(const SamplerConfigurationVisitor &other) = default;
+  virtual ~SamplerConfigurationVisitor()                                           = default;
 
   virtual void VisitAlwaysOff(const AlwaysOffSamplerConfiguration *model)                 = 0;
   virtual void VisitAlwaysOn(const AlwaysOnSamplerConfiguration *model)                   = 0;

sdk/include/opentelemetry/sdk/configuration/trace_id_ratio_based_sampler_configuration.h

@@ -18,9 +18,6 @@ namespace configuration
 class TraceIdRatioBasedSamplerConfiguration : public SamplerConfiguration
 {
 public:
-  TraceIdRatioBasedSamplerConfiguration()           = default;
-  ~TraceIdRatioBasedSamplerConfiguration() override = default;
-
   void Accept(SamplerConfigurationVisitor *visitor) const override
   {
     visitor->VisitTraceIdRatioBased(this);