disable deprecation warnings with clang-tidy jobs. Disable clang-tidy for protobuf generated code. Run iwyu in parallel.

Author: dbarker

.github/workflows/clang-tidy.yaml

@@ -13,7 +13,7 @@ jobs:
   clang-tidy:
     runs-on: ubuntu-24.04
     strategy:
-      fail-fast: true
+      fail-fast: false
       matrix:
         include:
           - cmake_options: all-options-abiv1-preview
@@ -31,10 +31,6 @@ jobs:
           submodules: recursive
 
       - name: Setup Environment
-        env:
-          PROTOBUF_VERSION: '23.3'
-          ABSEIL_CPP_VERSION: '20230125.3'
-          CXX_STANDARD: '14'
         run: |
           sudo apt update -y
           sudo apt install -y --no-install-recommends --no-install-suggests \
@@ -71,6 +67,7 @@ jobs:
             -DCMAKE_CXX_STANDARD=14 \
             -DWITH_STL=CXX14 \
             -DWITH_OPENTRACING=OFF \
+            -DCMAKE_CXX_FLAGS="-Wno-deprecated-declarations" \
             -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \
             -DCMAKE_CXX_CLANG_TIDY="clang-tidy;--quiet;-p;build-${{ matrix.cmake_options }}"
 
@@ -85,7 +82,6 @@ jobs:
 
       - name: Count warnings
         run: |
-          clang-tidy --version
           COUNT=$(grep -c "warning:" clang-tidy-${{ matrix.cmake_options }}.log)
           echo "clang-tidy reported ${COUNT} warning(s) with cmake options preset '${{ matrix.cmake_options }}'"
 

.github/workflows/iwyu.yml

@@ -14,7 +14,7 @@ jobs:
   iwyu:
     runs-on: ubuntu-latest
     strategy:
-      fail-fast: true
+      fail-fast: false
       matrix:
         include:
           - cmake_options: all-options-abiv1
@@ -57,26 +57,26 @@ jobs:
         run: |
           sudo ./ci/install_iwyu.sh
       - name: Prepare CMake
+        env:
+          CC: clang
+          CXX: clang++
         run: |
           TOPDIR=`pwd`
-          mkdir -p build-${{ matrix.cmake_options }} && cd build-${{ matrix.cmake_options }}
-          CC="clang" CXX="clang++" cmake \
-            -C ${TOPDIR}/test_common/cmake/${{ matrix.cmake_options }}.cmake \
+          cmake -B build-${{ matrix.cmake_options }} \
+            -C ./test_common/cmake/${{ matrix.cmake_options }}.cmake \
             -DCMAKE_CXX_STANDARD=14 \
             -DWITH_STL=CXX14 \
-            -DCMAKE_CXX_INCLUDE_WHAT_YOU_USE="include-what-you-use;-w;-Xiwyu;--mapping_file=${TOPDIR}/.iwyu.imp;" \
-            ..
+            -DCMAKE_CXX_INCLUDE_WHAT_YOU_USE="include-what-you-use;-w;-Xiwyu;--mapping_file=${TOPDIR}/.iwyu.imp;"
 
       - name: iwyu_tool
         run: |
-          cd build-${{ matrix.cmake_options }}
-          make -k 2>&1 | tee -a iwyu-${{ matrix.cmake_options }}.log
+          cmake --build build-${{ matrix.cmake_options }} -- -j$(nproc) -k 2>&1 | tee -a iwyu-${{ matrix.cmake_options }}.log
 
       - uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
         if: success() || failure()
         with:
           name: Logs-iwyu-${{ matrix.cmake_options }}
-          path: ./build-${{ matrix.cmake_options }}/*.log
+          path: ./iwyu-${{ matrix.cmake_options }}.log
 
       - name: count warnings
         run: |

cmake/opentelemetry-proto.cmake

@@ -318,9 +318,9 @@ target_include_directories(
   PUBLIC "$<BUILD_INTERFACE:${GENERATED_PROTOBUF_PATH}>"
          "$<INSTALL_INTERFACE:include>")
 
-# Disable include-what-you-use on generated code.
+# Disable include-what-you-use and clang-tidy on generated code.
 set_target_properties(opentelemetry_proto PROPERTIES CXX_INCLUDE_WHAT_YOU_USE
-                                                     "")
+                                                     "" CXX_CLANG_TIDY "")
 if(NOT Protobuf_INCLUDE_DIRS AND TARGET protobuf::libprotobuf)
   get_target_property(Protobuf_INCLUDE_DIRS protobuf::libprotobuf
                       INTERFACE_INCLUDE_DIRECTORIES)
@@ -338,9 +338,9 @@ if(WITH_OTLP_GRPC)
     ${LOGS_SERVICE_GRPC_PB_CPP_FILE} ${METRICS_SERVICE_GRPC_PB_CPP_FILE})
   set_target_version(opentelemetry_proto_grpc)
 
-  # Disable include-what-you-use on generated code.
+  # Disable include-what-you-use and clang-tidy on generated code.
   set_target_properties(opentelemetry_proto_grpc
-                        PROPERTIES CXX_INCLUDE_WHAT_YOU_USE "")
+                        PROPERTIES CXX_INCLUDE_WHAT_YOU_USE "" CXX_CLANG_TIDY "")
 
   list(APPEND OPENTELEMETRY_PROTO_TARGETS opentelemetry_proto_grpc)
   target_link_libraries(opentelemetry_proto_grpc PUBLIC opentelemetry_proto)

examples/grpc/CMakeLists.txt

@@ -41,8 +41,9 @@ add_custom_command(
 add_library(example_grpc_proto ${example_grpc_srcs} ${example_grpc_hdrs}
                                ${example_proto_srcs} ${example_proto_hdrs})
 
-# Disable include-what-you-use on generated code.
-set_target_properties(example_grpc_proto PROPERTIES CXX_INCLUDE_WHAT_YOU_USE "")
+# Disable include-what-you-use and clang-tidy on generated code.
+set_target_properties(example_grpc_proto PROPERTIES CXX_INCLUDE_WHAT_YOU_USE ""
+                                                    CXX_CLANG_TIDY "")
 
 target_include_directories(
   example_grpc_proto PUBLIC "$<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}>")

test_common/cmake/all-options.cmake

@@ -1,7 +1,7 @@
 # Copyright The OpenTelemetry Authors
 # SPDX-License-Identifier: Apache-2.0
 
-# Enable all options for opentelemetry-cpp cmake.
+# All options for the opentelemetry-cpp project.
 
 include(${CMAKE_CURRENT_LIST_DIR}/component-options.cmake)
 include(${CMAKE_CURRENT_LIST_DIR}/example-options.cmake)

test_common/cmake/component-options.cmake

@@ -1,7 +1,7 @@
 # Copyright The OpenTelemetry Authors
 # SPDX-License-Identifier: Apache-2.0
 
-# Enable all components in the OpenTelemetry C++ SDK.
+# All components options
 
 if(NOT DEFINED ENABLE_COMPONENTS)
     set(ENABLE_COMPONENTS ON)

test_common/cmake/example-options.cmake

@@ -1,7 +1,7 @@
 # Copyright The OpenTelemetry Authors
 # SPDX-License-Identifier: Apache-2.0
 
-# Enable all examples in the OpenTelemetry C++ SDK.
+# All examples options
 
 if(NOT DEFINED ENABLE_EXAMPLES)
     set(ENABLE_EXAMPLES ON)

test_common/cmake/preview-options.cmake

@@ -1,7 +1,7 @@
 # Copyright The OpenTelemetry Authors
 # SPDX-License-Identifier: Apache-2.0
 
-# Enable all preview features in the OpenTelemetry C++ SDK.
+# All preview feature options
 
 if(NOT DEFINED ENABLE_PREVIEW)
     set(ENABLE_PREVIEW ON)

test_common/cmake/testing-options.cmake

@@ -1,7 +1,7 @@
 # Copyright The OpenTelemetry Authors
 # SPDX-License-Identifier: Apache-2.0
 
-# Enable all tests in the OpenTelemetry C++ SDK.
+# All testing options
 
 if(NOT DEFINED ENABLE_TESTS)
     set(ENABLE_TESTS ON)