Skip to content

Commit ae8ed3a

Browse files
committed
Address the review comments
1 parent fbba434 commit ae8ed3a

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

exporters/memory/include/opentelemetry/exporters/memory/in_memory_span_exporter.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,12 +81,14 @@ class InMemorySpanExporter final : public opentelemetry::sdk::trace::SpanExporte
8181
}
8282

8383
/**
84-
* Timeout is an optional value containing the timeout of the exporter
84+
* Attempt to shut down the in-memory span exporter.
85+
* @param timeout Timeout is an optional value containing the timeout of the exporter
8586
* note: passing custom timeout values is not currently supported for this exporter
8687
* @return Returns the status of the operation
8788
*/
88-
bool Shutdown(std::chrono::microseconds /* timeout */) noexcept override
89+
bool Shutdown(std::chrono::microseconds timeout) noexcept override
8990
{
91+
(void)timeout;
9092
is_shutdown_ = true;
9193
return true;
9294
}

sdk/include/opentelemetry/sdk/trace/recordable.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,10 @@ class Recordable
5656

5757
/**
5858
* Set an attribute of a span.
59-
* @param name the name of the attribute
59+
* @param key the name of the attribute
6060
* @param value the attribute value
6161
*/
62-
virtual void SetAttribute(nostd::string_view name,
62+
virtual void SetAttribute(nostd::string_view key,
6363
const opentelemetry::common::AttributeValue &value) noexcept = 0;
6464

6565
/**

0 commit comments

Comments
 (0)