Code review feedback

chusitoo · chusitoo · commit afe9e5a69713 · 2024-11-05T22:31:07.000-05:00
diff --git a/ext/src/http/client/curl/http_operation_curl.cc b/ext/src/http/client/curl/http_operation_curl.cc
@@ -658,7 +658,7 @@ CURLcode HttpOperation::Setup()
     return rc;
   }
 #else
-  rc = SetCurlLongOption(CURLOPT_VERBOSE, static_cast<long>(is_log_enabled_ || kEnableCurlLogging));
+  rc = SetCurlLongOption(CURLOPT_VERBOSE, (is_log_enabled_ && kEnableCurlLogging) ? 1L : 0L;
   if (rc != CURLE_OK)
   {
     return rc;

Original file line number	Diff line number	Diff line change
`@@ -658,7 +658,7 @@ CURLcode HttpOperation::Setup()`
`658`	`658`	`return rc;`
`659`	`659`	`}`
`660`	`660`	`#else`
`661`		`- rc = SetCurlLongOption(CURLOPT_VERBOSE, static_cast<long>(is_log_enabled_ \|\| kEnableCurlLogging));`
	`661`	`+ rc = SetCurlLongOption(CURLOPT_VERBOSE, (is_log_enabled_ && kEnableCurlLogging) ? 1L : 0L;`
`662`	`662`	`if (rc != CURLE_OK)`
`663`	`663`	`{`
`664`	`664`	`return rc;`