fix ci issues. set fPIC on opentracing builds. revert changes to the cmake_install.yml so googletest and benchmark are installed. add missing curl packages to ci.yml tests

Author: dbarker

.github/workflows/ci.yml

@@ -361,6 +361,7 @@ jobs:
         CXX: /usr/bin/g++-12
       run: |
         sudo -E ./ci/setup_ci_environment.sh
+        sudo -E apt-get install -y zlib1g-dev libcurl4-openssl-dev
     - name: run cmake tests (without otlp-exporter)
       env:
         CC: /usr/bin/gcc-12
@@ -1172,6 +1173,7 @@ jobs:
           CXX: /usr/bin/g++-12
         run: |
           sudo -E ./ci/setup_ci_environment.sh
+          sudo -E apt-get install -y zlib1g-dev libcurl4-openssl-dev
       - name: run w3c trace-context test server (background)
         env:
           CXX_STANDARD: '14'

.github/workflows/cmake_install.yml

@@ -71,13 +71,14 @@ jobs:
     - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
       with:
         submodules: 'recursive'
-    - name: Setup Environment
+    - name: Install libcurl, zlib, nlohmann-json with apt
       run: |
         sudo -E ./ci/setup_ci_environment.sh
-    - name: Install Dependencies
+        sudo -E ./ci/setup_googletest.sh
+    - name: Install abseil, protobuf, and grpc with apt
       run: |
         sudo -E apt-get update
-        sudo -E apt-get install -y zlib1g-dev libcurl4-openssl-dev nlohmann-json3-dev libabsl-dev libprotobuf-dev libgrpc++-dev protobuf-compiler protobuf-compiler-grpc
+        sudo -E apt-get install -y libabsl-dev libprotobuf-dev libgrpc++-dev protobuf-compiler protobuf-compiler-grpc
     - name: Run Tests (static libs)
       env:
         BUILD_SHARED_LIBS: 'OFF'
@@ -97,6 +98,7 @@ jobs:
       # Versions below set to the latest version available
       # The abseil and protobuf versions are taken from
       # the grpc submodules at the GRPC_VERSION tag
+      GOOGLETEST_VERSION: '1.16.0'
       ABSEIL_CPP_VERSION: '20240722.1'
       PROTOBUF_VERSION: '29.0'
       GRPC_VERSION: 'v1.71.0'
@@ -110,12 +112,12 @@ jobs:
     - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
       with:
         submodules: 'recursive'
-    - name: Setup Environment
+    - name: Install gtest, libcurl, zlib, nlohmann-json with apt
       run: |
         sudo -E ./ci/setup_ci_environment.sh
-    - name: Install Dependencies
+        sudo -E ./ci/setup_googletest.sh
+    - name: Build abseil, protobuf, and grpc with ci scripts
       run: |
-        sudo -E apt-get install -y zlib1g-dev libcurl4-openssl-dev
         sudo -E ./ci/install_abseil.sh
         sudo -E ./ci/install_protobuf.sh
         sudo -E ./ci/setup_grpc.sh -r $GRPC_VERSION -s $CXX_STANDARD -p protobuf -p abseil-cpp
@@ -132,6 +134,7 @@ jobs:
       CXX_STANDARD: '17'
       # These are stable versions tested in the main ci workflow
       # and defaults in the devcontainer
+      GOOGLETEST_VERSION: '1.14.0'
       ABSEIL_CPP_VERSION: '20230125.3'
       PROTOBUF_VERSION: '23.3'
       GRPC_VERSION: 'v1.55.0'
@@ -145,12 +148,12 @@ jobs:
     - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
       with:
         submodules: 'recursive'
-    - name: Setup Environment
+    - name: Install gtest, libcurl, zlib, nlohmann-json with apt
       run: |
         sudo -E ./ci/setup_ci_environment.sh
-    - name: Install Dependencies
+        sudo -E ./ci/setup_googletest.sh
+    - name: Build abseil, protobuf, and grpc with ci scripts
       run: |
-        sudo -E apt-get install -y zlib1g-dev libcurl4-openssl-dev
         sudo -E ./ci/install_abseil.sh
         sudo -E ./ci/install_protobuf.sh
         sudo -E ./ci/setup_grpc.sh -r $GRPC_VERSION -s $CXX_STANDARD -p protobuf -p abseil-cpp
@@ -172,6 +175,8 @@ jobs:
       CMAKE_VERSION: '3.14.0'
       # cxx14 is the default for Ubuntu 22.04
       CXX_STANDARD: '14'
+      # This is the apt package version of googletest for Ubuntu 22.04
+      GOOGLETEST_VERSION: '1.11.0'
       # These are minimum versions tested in the main ci workflow
       ABSEIL_CPP_VERSION: '20220623.2'
       PROTOBUF_VERSION: '21.12'
@@ -186,13 +191,13 @@ jobs:
     - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
       with:
         submodules: 'recursive'
-    - name: Setup Environment
+    - name: Install gtest, libcurl, zlib, nlohmann-json with apt
       run: |
         sudo -E ./ci/setup_ci_environment.sh
         sudo -E ./ci/setup_cmake.sh
-    - name: Install Dependencies
+        sudo -E ./ci/setup_googletest.sh
+    - name: Build abseil, protobuf, and grpc with ci scripts
       run: |
-        sudo -E apt-get install -y zlib1g-dev libcurl4-openssl-dev
         sudo -E ./ci/install_abseil.sh
         sudo -E ./ci/install_protobuf.sh
         sudo -E ./ci/setup_grpc.sh -r $GRPC_VERSION -s $CXX_STANDARD -p protobuf -p abseil-cpp

ci/do_ci.sh

@@ -238,6 +238,7 @@ elif [[ "$1" == "cmake.opentracing_shim.test" ]]; then
   cmake "${CMAKE_OPTIONS[@]}" \
         -DCMAKE_CXX_FLAGS="-Werror -Wno-error=redundant-move $CXXFLAGS" \
         -DWITH_OPENTRACING=ON \
+        -DCMAKE_POSITION_INDEPENDENT_CODE=ON \
         "${SRC_DIR}"
   make -j $(nproc)
   make test
@@ -249,6 +250,7 @@ elif [[ "$1" == "cmake.opentracing_shim.install.test" ]]; then
   cmake "${CMAKE_OPTIONS[@]}" \
         -DCMAKE_CXX_FLAGS="-Werror -Wno-error=redundant-move $CXXFLAGS" \
         -DWITH_OPENTRACING=ON \
+        -DCMAKE_POSITION_INDEPENDENT_CODE=ON \
         -DCMAKE_INSTALL_PREFIX=${INSTALL_TEST_DIR} \
         "${SRC_DIR}"
   make -j $(nproc)