Skip to content

Commit b3b277e

Browse files
committed
Fixes comments
1 parent 9597fca commit b3b277e

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

cmake/opentelemetry-proto.cmake

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -222,9 +222,9 @@ elseif(PROTOBUF_VERSION AND PROTOBUF_VERSION VERSION_LESS "3.16")
222222
endif()
223223

224224
# protobuf uses numerous global variables, which can lead to conflicts when a
225-
# user's dynamic libraries, executables, and otel-cpp are all built with
226-
# -fvisibility=hidden and linked against a statically built protobuf library.
227-
# This may result in crashes. To prevent such conflicts, we also need to build
225+
# user's dynamic libraries, executables, and otel-cpp are all built as dynamic
226+
# libraries and linked against a statically built protobuf library. This may
227+
# result in crashes. To prevent such conflicts, we also need to build
228228
# opentelemetry_exporter_otlp_grpc_client as a static library.
229229
if(TARGET protobuf::libprotobuf)
230230
get_target_property(protobuf_lib_type protobuf::libprotobuf TYPE)

exporters/otlp/CMakeLists.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,9 @@ target_link_libraries(opentelemetry_otlp_recordable
3434
if(WITH_OTLP_GRPC)
3535
find_package(gRPC REQUIRED)
3636
# gRPC uses numerous global variables, which can lead to conflicts when a
37-
# user's dynamic libraries, executables, and otel-cpp are all built with
38-
# -fvisibility=hidden and linked against a statically built gRPC library. This
39-
# may result in crashes. To prevent such conflicts, we also need to build
37+
# user's dynamic libraries, executables, and otel-cpp are all built as dynamic
38+
# libraries and linked against a statically built gRPC library. This may
39+
# result in crashes. To prevent such conflicts, we also need to build
4040
# opentelemetry_exporter_otlp_grpc_client as a static library.
4141
get_target_property(grpc_lib_type gRPC::grpc++ TYPE)
4242
# grpc_lib_type may be "INTERFACE_LIBRARY" in some build systems, such as

0 commit comments

Comments
 (0)