Refresh code from PR #2518, to fix review comments.

Author: marcalff

examples/configuration/custom_log_record_exporter.h

@@ -15,7 +15,7 @@
 class CustomLogRecordExporter : public opentelemetry::sdk::logs::LogRecordExporter
 {
 public:
-  CustomLogRecordExporter(const std::string & /* comment */) {}
+  CustomLogRecordExporter(const std::string &comment) : comment_(comment) {}
   CustomLogRecordExporter(CustomLogRecordExporter &&)                      = delete;
   CustomLogRecordExporter(const CustomLogRecordExporter &)                 = delete;
   CustomLogRecordExporter &operator=(CustomLogRecordExporter &&)           = delete;
@@ -31,4 +31,7 @@ class CustomLogRecordExporter : public opentelemetry::sdk::logs::LogRecordExport
   bool ForceFlush(std::chrono::microseconds timeout) noexcept override;
 
   bool Shutdown(std::chrono::microseconds timeout) noexcept override;
+
+private:
+  std::string comment_;
 };

examples/configuration/custom_log_record_processor.h

@@ -13,7 +13,7 @@
 class CustomLogRecordProcessor : public opentelemetry::sdk::logs::LogRecordProcessor
 {
 public:
-  CustomLogRecordProcessor(const std::string &comment) : m_comment(comment) {}
+  CustomLogRecordProcessor(const std::string &comment) : comment_(comment) {}
   CustomLogRecordProcessor(CustomLogRecordProcessor &&)                      = delete;
   CustomLogRecordProcessor(const CustomLogRecordProcessor &)                 = delete;
   CustomLogRecordProcessor &operator=(CustomLogRecordProcessor &&)           = delete;
@@ -29,5 +29,5 @@ class CustomLogRecordProcessor : public opentelemetry::sdk::logs::LogRecordProce
   bool Shutdown(std::chrono::microseconds timeout) noexcept override;
 
 private:
-  std::string m_comment;
+  std::string comment_;
 };

examples/configuration/custom_pull_metric_exporter.h

@@ -12,7 +12,7 @@
 class CustomPullMetricExporter : public opentelemetry::sdk::metrics::MetricReader
 {
 public:
-  CustomPullMetricExporter(const std::string & /* comment */) {}
+  CustomPullMetricExporter(const std::string &comment) : comment_(comment) {}
   CustomPullMetricExporter(CustomPullMetricExporter &&)                      = delete;
   CustomPullMetricExporter(const CustomPullMetricExporter &)                 = delete;
   CustomPullMetricExporter &operator=(CustomPullMetricExporter &&)           = delete;
@@ -27,4 +27,7 @@ class CustomPullMetricExporter : public opentelemetry::sdk::metrics::MetricReade
   bool OnShutDown(std::chrono::microseconds timeout) noexcept override;
 
   void OnInitialized() noexcept override;
+
+private:
+  std::string comment_;
 };

examples/configuration/custom_push_metric_exporter.h

@@ -13,7 +13,7 @@
 class CustomPushMetricExporter : public opentelemetry::sdk::metrics::PushMetricExporter
 {
 public:
-  CustomPushMetricExporter(const std::string & /* comment */) {}
+  CustomPushMetricExporter(const std::string &comment) : comment_(comment) {}
   CustomPushMetricExporter(CustomPushMetricExporter &&)                      = delete;
   CustomPushMetricExporter(const CustomPushMetricExporter &)                 = delete;
   CustomPushMetricExporter &operator=(CustomPushMetricExporter &&)           = delete;
@@ -29,4 +29,7 @@ class CustomPushMetricExporter : public opentelemetry::sdk::metrics::PushMetricE
   bool ForceFlush(std::chrono::microseconds timeout) noexcept override;
 
   bool Shutdown(std::chrono::microseconds timeout) noexcept override;
+
+private:
+  std::string comment_;
 };

examples/configuration/custom_sampler.h

@@ -16,7 +16,7 @@
 class CustomSampler : public opentelemetry::sdk::trace::Sampler
 {
 public:
-  CustomSampler(const std::string & /* comment */) {}
+  CustomSampler(const std::string &comment) : comment_(comment) {}
   CustomSampler(CustomSampler &&)                      = delete;
   CustomSampler(const CustomSampler &)                 = delete;
   CustomSampler &operator=(CustomSampler &&)           = delete;
@@ -32,4 +32,7 @@ class CustomSampler : public opentelemetry::sdk::trace::Sampler
       const opentelemetry::trace::SpanContextKeyValueIterable &links) noexcept override;
 
   opentelemetry::nostd::string_view GetDescription() const noexcept override;
+
+private:
+  std::string comment_;
 };

examples/configuration/custom_span_exporter.h

@@ -15,7 +15,7 @@
 class CustomSpanExporter : public opentelemetry::sdk::trace::SpanExporter
 {
 public:
-  CustomSpanExporter(const std::string & /* comment */) {}
+  CustomSpanExporter(const std::string &comment) : comment_(comment) {}
   CustomSpanExporter(CustomSpanExporter &&)                      = delete;
   CustomSpanExporter(const CustomSpanExporter &)                 = delete;
   CustomSpanExporter &operator=(CustomSpanExporter &&)           = delete;
@@ -31,4 +31,7 @@ class CustomSpanExporter : public opentelemetry::sdk::trace::SpanExporter
   bool ForceFlush(std::chrono::microseconds timeout) noexcept override;
 
   bool Shutdown(std::chrono::microseconds timeout) noexcept override;
+
+private:
+  std::string comment_;
 };

examples/configuration/custom_span_processor.h

@@ -14,7 +14,7 @@
 class CustomSpanProcessor : public opentelemetry::sdk::trace::SpanProcessor
 {
 public:
-  CustomSpanProcessor(const std::string &comment) : m_comment(comment) {}
+  CustomSpanProcessor(const std::string &comment) : comment_(comment) {}
   CustomSpanProcessor(CustomSpanProcessor &&)                      = delete;
   CustomSpanProcessor(const CustomSpanProcessor &)                 = delete;
   CustomSpanProcessor &operator=(CustomSpanProcessor &&)           = delete;
@@ -33,5 +33,5 @@ class CustomSpanProcessor : public opentelemetry::sdk::trace::SpanProcessor
   bool Shutdown(std::chrono::microseconds timeout) noexcept override;
 
 private:
-  std::string m_comment;
+  std::string comment_;
 };